Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for every huge page resource, we need to remove it from allocatable memory when Updating Node Allocatable limit across pods #96255

Closed
wants to merge 1 commit into from
Closed

for every huge page resource, we need to remove it from allocatable memory when Updating Node Allocatable limit across pods #96255

wants to merge 1 commit into from

Conversation

mysunshine92
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:

in os operating system cgroup aspect，since memory use do not include hugepage use，we need to remove huge page resource from allocatable memory when Updating Node Allocatable limit across pods.
here:
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/node_container_manager_linux.go#L184

Which issue(s) this PR fixes:

Fixes #84426

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@mysunshine92
for every huge page resource, we need to remove it from allocatable m…
018b465 
…emory when Updating Node Allocatable limit across pods
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 5, 2020
@k8s-ci-robot
Copy link
Contributor

@mysunshine92: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2020
@mysunshine92
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@mysunshine92
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@mysunshine92
Copy link
Contributor Author

cc @derekwaynecarr

@mysunshine92
Copy link
Contributor Author

/assign @derekwaynecarr

@mysunshine92
Copy link
Contributor Author

cc @vishh

@mysunshine92
Copy link
Contributor Author

cc @derekwaynecarr

@mysunshine92
Copy link
Contributor Author

cc @Random-Liu

@AlexeyPerevalov
Copy link
Contributor

AlexeyPerevalov commented Nov 12, 2020 •
edited

/cc

For pod QoS classes guaranteed and burstable this change fixes minor issue, since this bug is hidden by kube-scheduler which takes into account v1.Node.Status.Allocatable, as was mentioned in #84426 (comment).
But if pod with besteffort QoS will start on worker node only top level cgroup will limit its memory usage, in our case it's memory/kubepod.slice/. And there will be not an allocatable value, but capacity (which is higher and includes hugepage amount). So the workload in pod will faced with out of memory not because due to cgroup limit, but with higher probability because of memory exceeding on the host.

So it's better to fix it.

AlexeyPerevalov
AlexeyPerevalov suggested changes Nov 12, 2020
View reviewed changes
pkg/kubelet/cm/node_container_manager_linux.go
@@ -197,6 +198,20 @@ func (cm *containerManagerImpl) getNodeAllocatableAbsoluteImpl(capacity v1.Resou
}
result[k] = value
}

for k, v := range result {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodestatus in its setters.go is doing the same job. Since nodestatus uses cm package, maybe somehow make a common code in cm for it, because now this code duplication looks not so good.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mysunshine92
To complete the pull request process, please assign derekwaynecarr after the PR has been reviewed.
You can assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ehashman ehashman added this to Needs Reviewer in SIG Node PR Triage Jan 6, 2021
@ehashman ehashman moved this from Needs Reviewer to Waiting on Author in SIG Node PR Triage Jan 12, 2021
@ehashman
Copy link
Member

ehashman commented Feb 4, 2021

/hold

while waiting on author

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2021
@odinuge odinuge mentioned this pull request Mar 26, 2021
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 4, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node PR Triage automation moved this from Waiting on Author to Done Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyPerevalov AlexeyPerevalov AlexeyPerevalov requested changes

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@vishh vishh Awaiting requested review from vishh

Assignees

@derekwaynecarr derekwaynecarr

Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
No milestone
6 participants
@mysunshine92 @k8s-ci-robot @AlexeyPerevalov @ehashman @fejta-bot @derekwaynecarr