Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove section on dockershim #30979

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Remove section on dockershim #30979

merged 1 commit into from
Dec 16, 2021

Conversation

ystkfujii
Copy link
Contributor

Remove section on dockerhim

see : #30961 (review)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2021
@netlify
Copy link

netlify bot commented Dec 15, 2021

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: e138c8b

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61b9eaf8ea0a000008687104

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 15, 2021
@ystkfujii ystkfujii mentioned this pull request Dec 15, 2021
Merged
sftim
sftim reviewed Dec 15, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sftim
Copy link
Contributor

sftim commented Dec 15, 2021

/milestone 1.24

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Dec 15, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f8541dd9e612c23539644ad56831e896e32c7e35

@reylejano
Copy link
Member

Dockershim has been removed from kubelet in k/k master in PR kubernetes/kubernetes#97252
/cc @nate-double-u
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit e0c5205 into kubernetes:dev-1.24 Dec 16, 2021
@ystkfujii ystkfujii deleted the remove_section_on_dockershim branch March 4, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@tallclair tallclair Awaiting requested review from tallclair

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ystkfujii @sftim @k8s-ci-robot @reylejano