-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured Logging migration: modify node and pod part logs of kubelet. #98847
Conversation
Hi @yangjunmyfm192085. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3ceda42
to
6bcb907
Compare
@yangjunmyfm192085 can you give more context about this PR? Do you have a related issue to link to? |
|
Are you working with sig-instrumentation? It looks like none of your PRs (#98847 and #98850) are actually treating these files... /cc @serathius |
/retest |
/hold cancel |
8528d2c
to
6fc4034
Compare
@yangjunmyfm192085 do you still mean to have this extra author in the commit? You probably need a: |
thank you,I will try at once |
Signed-off-by: JunYang <yang.jun22@zte.com.cn>
6fc4034
to
90bfd38
Compare
I have fixed it, thank you very much.@kikisdeliveryservice @ehashman |
/test pull-kubernetes-unit |
/test pull-kubernetes-e2e-kind |
Yay! Glad you got it sorted 😸 @yangjunmyfm192085 |
return false | ||
} | ||
// pod's containers should be deleted | ||
runtimeStatus, err := kl.podCache.Get(pod.UID) | ||
if err != nil { | ||
klog.V(3).Infof("Pod %q is terminated, Error getting runtimeStatus from the podCache: %s", format.Pod(pod), err) | ||
klog.V(3).InfoS("Pod is terminated, Error getting runtimeStatus from the podCache", "pod", klog.KObj(pod), "err", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Error/error
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, yangjunmyfm192085 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: JunYang yang.jun22@zte.com.cn
What type of PR is this?
/kind feature
What this PR does / why we need it:
Structured Logging migration: modify node and pod part logs of kubelet.
xref:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
part of kubernetes/enhancements#1602
As it is related to log, change the log here to structured log.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: