Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mehabhalodiya as (en) reviewer for SIG Docs #3102

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Add mehabhalodiya as (en) reviewer for SIG Docs #3102

merged 1 commit into from
Nov 17, 2021

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Nov 16, 2021

I invited @mehabhalodiya to become a reviewer for the upstream (English) localization for k/website.

This PR will add Meha as a reviewer for English.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 16, 2021
@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2021
@sftim sftim mentioned this pull request Nov 16, 2021
Merged
@sftim sftim marked this pull request as ready for review November 16, 2021 22:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2021
@divya-mohan0209
Copy link
Contributor

/lgtm from my side

@dims
Copy link
Member

dims commented Nov 17, 2021

/approve
/lgtm

@sftim
Copy link
Contributor Author

sftim commented Nov 17, 2021

Thanks folks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1b688cf into kubernetes:main Nov 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 17, 2021
@mehabhalodiya
Copy link

Thanks a lot @dims @divya-mohan0209 @sftim for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
5 participants
@sftim @k8s-ci-robot @divya-mohan0209 @dims @mehabhalodiya