-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support overriding upstream #28
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
case strings.HasPrefix(path, "/v1/"): | ||
doV1(w, r, upstreamRegistry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this ? GCR stopped to serve v1
API.
HTTP/2 404
date: Mon, 21 Mar 2022 21:46:57 GMT
content-type: text/html; charset=UTF-8
server: Docker Registry
content-length: 1579
x-xss-protection: 0
x-frame-options: SAMEORIGIN
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do that cleanup in a different PR, v1 support here is purely a minor refactor
/lgtm |
Followup of: - kubernetes/registry.k8s.io#28 Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
fixes #26