Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial redirector service implementation #5

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

BenTheElder
Copy link
Member

  • add Umbrella issue: k8s.gcr.io => registry.k8s.io solution k8s.io#1834 (comment) (with git "Co-authored-by" attribution), and gives it a name: αρχείο (archeío) is roughly? Greek for "registry".
  • add a README with some detail
  • add makefile + boilerplate scripts adapted from kubernetes-sigs/kind (we've also previously adapted these for kubernetes-sigs/kubetest2 and kubernetes/test-infra)
    • this also includes vendoring gimme from HEAD, which makes the PR look bigger than it is 🙃
  • stub in building an image with ko

I'll work more on that last part tomorrow.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 27, 2022
Comment on lines +43 to +44
case strings.HasPrefix(path, "/v1/"):
doV1(w, r)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to maintain compatibility for the v1. The old docker clients will be served by k8s.gcr.io.

@ameukam
Copy link
Member

ameukam commented Jan 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8c910fe into kubernetes:main Jan 27, 2022
@ameukam
Copy link
Member

ameukam commented Jan 27, 2022

Followup:

  • automate image building with cloudbuild
  • have presubmits running some tests
  • build the infrastructure for it.

@BenTheElder BenTheElder mentioned this pull request Jan 27, 2022
@BenTheElder BenTheElder deleted the archeio branch January 27, 2022 07:42
@BenTheElder
Copy link
Member Author

#7 for CI
#6 for whoops :-)

Also FYI:
With this makefile you either need shellcheck installed at the latest version (v0.8.0) or docker to run make shellcheck / make verify, the rest require just make/bash/posix and auto manage a go toolchain with gimme (vendored).

Other tools are managed with hack/tools go module, including ko (for distroless image builds without docker), gotestsum (nicer test results + junit for CI), golangci-lint (for linting).

The targets should otherwise be fairly self explanatory / commented, I think ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants