Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release blocking issues (1.19.0-beta.0, 1.18.3, 1.17.6, 1.16.10) #1281

Closed
19 tasks done
justaugustus opened this issue May 13, 2020 · 5 comments
Closed
19 tasks done

Release blocking issues (1.19.0-beta.0, 1.18.3, 1.17.6, 1.16.10) #1281

justaugustus opened this issue May 13, 2020 · 5 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone

Comments

@justaugustus
Copy link
Member

justaugustus commented May 13, 2020

There are a few issues blocking releases right now and I realized there's not a singular place tracking them, so I'm opening this up.

Required

kube-cross and k8s-cloud-builder:

Branch cut:

Release notes:

Nice-to-have

/assign
/kind bug
/priority critical-urgent
cc: @kubernetes/release-engineering

@justaugustus justaugustus added kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels May 13, 2020
@justaugustus
Copy link
Member Author

/priority critical-urgent

@saschagrunert
Copy link
Member

Proposal for the branch cutting changes:

  1. Add a new variant beta to the current krel gcbmgr --type flag, which is currently:
    --type string Release type (must be one of: 'prerelease', 'rc', 'official')
  2. Pass that flag via the GCB substitutions to anago
  3. Modify anago (this seems to be the funny part) to not enforce alpha releases on the master and allow betas by taking the new release type into account. I guess one (of some) critical code part(s) is here:

    release/anago

    Lines 471 to 492 in c600d12

    # NOTE: For new branches, files are still also updated on master (CHANGELOG).
    # Therefore, while the new branch may be based on a commit earlier than
    # HEAD, all master activity must occur AT HEAD.
    if [[ -n "$PARENT_BRANCH" ]]; then
    if [[ $RELEASE_VERSION_PRIME == $version ]]; then
    if [[ $tree_object =~ release- ]] && \
    ! git rev-parse $tree_object >/dev/null 2>&1; then
    # Only create/reset (-B) and set a branch_point if the *release-*
    # branch doesn't already exist locally
    branch_arg="-b"
    # Use BRANCH_POINT if set, otherwise, the hash from
    # JENKINS_BUILD_VERSION
    branch_point=${BRANCH_POINT:-$commit}
    fi
    else
    # if this is not the PRIMary version on the named RELEASE_BRANCH, use the
    # parent
    tree_object=$PARENT_BRANCH
    fi
    else
    [[ $label == "alpha" ]] && tree_object="$commit"
    fi

@justaugustus
Copy link
Member Author

Proposal for the branch cutting changes:

@saschagrunert -- Let's bring this discussion to the branch strategy issue. Commented here: #1207 (comment)

@justaugustus
Copy link
Member Author

This is complete.
/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closing this issue.

In response to this:

This is complete.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus unpinned this issue May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

3 participants