-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log in to DockerHub during staging before starting build #1979
Conversation
Add a call to docker login using the token from the environment Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Add the docker hub user token to the encrypted environment Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Cancel if you’re ready. 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Test run worked. Merging |
What type of PR is this?
/kind feature
What this PR does / why we need it:
During the
v1.21.0-rc.0
cut we had issues pulling images from Docker Hub. Now, krel will log using a docker account into hub before starting the build to try to avoid getting rate limited.Which issue(s) this PR fixes:
Related to problems during the release cut kubernetes/sig-release#1489
Special notes for your reviewer:
Does this PR introduce a user-facing change?