-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go] Build go1.16.6 and go1.15.14 images #2162
[go] Build go1.16.6 and go1.15.14 images #2162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Please make sure that you also change the following files to fix the presubmit failure:
- images/releng/k8s-ci-builder/Makefile
- images/releng/k8s-ci-builder/Dockerfile
- images/releng/k8s-ci-builder/variants.yaml
9ad45cf
to
ea7f72c
Compare
/test pull-release-image-go-runner |
These files should be updated after updating kubernetes/kubernetes. The previous error was probably because I accidentally changed the version of the section under dependents.yaml:
It has been modified back to the original version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mengjiao-liu!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, mengjiao-liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area dependency release-eng/security
What this PR does / why we need it:
Tracking issue: #2157
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/assign @thejoycekung @saschagrunert @puerco @justaugustus
cc @kubernetes/release-engineering