-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule-builder: add new field #2173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for following up on this! 🙏
/retest |
@saschagrunert fixed the tests 😅 |
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
more tests, I should run it before pushing 😓 |
/test pull-release-integration-test |
@saschagrunert can I have a lgtm? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
While updating the patch schedule for this PR kubernetes/website#28971 notice that we have a new field called
note
and the schedule-builder weas failing.Adding the notes field and the schedule was generated using this patch
/assign @saschagrunert @puerco
cc @kubernetes/release-engineering
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?