Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang: Build 1.19beta1 images #2576

Merged
merged 4 commits into from
Jun 22, 2022
Merged

golang: Build 1.19beta1 images #2576

merged 4 commits into from
Jun 22, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 20, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • remove old and not used dependency for 1.20
  • add dependencies for v1.24 release
  • drop v1.24-go1.17-bullseye config for kube-cross
  • golang: Build 1.19beta1 images

/hold to check if all looks good
/assign @justaugustus @saschagrunert @puerco @Verolop @palnabarun
cc @kubernetes/release-managers

Which issue(s) this PR fixes:

None
xref: #2575

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- remove old and not used dependency for 1.20
- add dependencies for v1.24 release
- drop v1.24-go1.17-bullseye config for kube-cross
- golang: Build 1.19beta1 images

@cpanato
remove old and not used dependency
1421909 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
add dependencies for v1.24 release
af9e7ef 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
drop v1.24-go1.17-bullseye config for kube-cross
611fea8 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 20, 2022
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 20, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2022
@cpanato cpanato changed the title golang: Build 1.18beta1 images golang: Build 1.19beta1 images Jun 20, 2022
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Jun 20, 2022
@cpanato cpanato mentioned this pull request Jun 20, 2022
Closed
40 tasks
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 20, 2022
@ameukam
Copy link
Member

ameukam commented Jun 21, 2022

/test pull-release-image-kube-cross

@cpanato
Copy link
Member Author

cpanato commented Jun 21, 2022

/test pull-release-image-k8s-ci-builder

@cpanato
Copy link
Member Author

cpanato commented Jun 21, 2022

/test pull-release-image-kube-cross

@cpanato
Copy link
Member Author

cpanato commented Jun 21, 2022

/test pull-release-integration-test

@cpanato
Copy link
Member Author

cpanato commented Jun 21, 2022

/test pull-release-image-k8s-ci-builder

@cpanato
Copy link
Member Author

cpanato commented Jun 21, 2022

/test pull-release-image-releng-ci
/test pull-release-image-kube-cross

@cpanato
golang: Build 1.19beta1 images
3dca5b7 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Jun 21, 2022

/test pull-release-image-go-runner

@ameukam
Copy link
Member

ameukam commented Jun 21, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2022
saschagrunert
saschagrunert approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Jun 22, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1da89e6 into kubernetes:master Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 22, 2022
@cpanato cpanato deleted the go19 branch June 22, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@mkorbi mkorbi Awaiting requested review from mkorbi

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@Verolop Verolop

@ameukam ameukam

@puerco puerco

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
8 participants
@cpanato @ameukam @k8s-ci-robot @saschagrunert @justaugustus @Verolop @puerco @palnabarun