Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Kubernetes Source Code" from being published on GitHub Releases #2780

Merged
merged 1 commit into from May 30, 2023
Merged

Remove "Kubernetes Source Code" from being published on GitHub Releases #2780

merged 1 commit into from May 30, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 29, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As discussed in kubernetes/kubernetes#100460 and announced in https://groups.google.com/a/kubernetes.io/g/dev/c/mLAxBdgawcM/m/vSew-lLdAgAJ, we're removing the "Kubernetes Source Code" artifact from GitHub Releases.

This change will go into effect starting with the January patch releases.

Which issue(s) this PR fixes:

Fixes kubernetes/kubernetes#100460

Special notes for your reviewer:

This change is supposed to go into effect for January patch releases, so I'll put this PR on hold until then.
/hold

Does this PR introduce a user-facing change?

Remove "Kubernetes Source Code" artifact from being published on GitHub Releases

cc @kubernetes/release-engineering FYI

@xmudrii
Remove "Kubernetes Source Code" from being published on GitHub
a73cf7a 
As discussed in kubernetes/kubernetes#100460
and announced in https://groups.google.com/a/kubernetes.io/g/dev/c/mLAxBdgawcM/m/vSew-lLdAgAJ
we're removing the "Kubernetes Source Code" artifact from GitHub
Releases.

This change will go into effect starting with the January
patch releases.

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 29, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2022
@xmudrii xmudrii mentioned this pull request Nov 29, 2022
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@puerco
Copy link
Member

puerco commented Nov 30, 2022 •
edited

OK, this lgtm but should we rethink what we are uploading here or not now? Uploading the sbom at least leaves a trace to where the artifacts are. And it is in the same directory as the tar, so we don't need to change a lot.

@saschagrunert
Copy link
Member

OK, this lgtm but should we rethink what we are uploading here or not now? Uploading the sbom at least leaves a trace to where the artifacts are. And it is in the same directory as the tar, so we don't need to change a lot.

Let's split this question out and integrate into one of the existing KEPs. We can argue why we should host stuff on GitHub since there is an API rate limiting and we already have all artifacts on GCS.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Feb 28, 2023

Let's proceed with this one after February patch releases.
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 29, 2023
@xmudrii
Copy link
Member Author

xmudrii commented May 29, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 29, 2023
@saschagrunert
Copy link
Member

@xmudrii have we agreed on moving forward with this?

@xmudrii
Copy link
Member Author

xmudrii commented May 30, 2023

As discussed at SIG Release meeting held on 2023-05-30, we're proceeding with this
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 59e48b0 into kubernetes:master May 30, 2023
1 check passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 30, 2023
@xmudrii xmudrii deleted the rm-k8s-source-code branch May 30, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

Consider renaming 'Kubernetes Source Code' release artifacts
6 participants
@xmudrii @k8s-ci-robot @puerco @saschagrunert @k8s-triage-robot @cpanato