Refactor krel obs specs command
#3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
area/release-eng
k8s-ci-robot
added
sig/release
|
I assume we don't break anything existing with that change, correct? |
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
That's correct, this command is not used at all currently. |
saschagrunert
approved these changes
May 25, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-release-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
krel obs specscommand was initially implemented as a clone ofkubepkgfor the proof-of-concept purposes. Given that, there are some issues:kubepkgwas created with an idea to support both building specs and running the build process. Running the build process is not needed with the OBS workflow because OBS is taking care of thatkubepkgwas supporting both Deb and RPM packages/specs, but Deb packages/specs are now autogenerated on build time with debbuild in the OBS pipelinekrel obs specsfromkrel stage(before binaries are available ondl.k8s.io)krel obs specsto be universal and reusable, i.e. that any Kubernetes subproject can use this toolThe idea behind this subcommand was presented on SIG Release meeting held on 2023-05-23.
This PR refactors the
krel obs specssubcommand to accomplish goals stated above. Significant changes include:krel obs specsnow works with a single package instead of multiple packages. There's going to be a wrapper on top of this command (krel obs stage) that's going to support multiple packages and work with OBScmd/krel/templates/latest/metadata.yaml). Previously, those information was stored inside thekubepkg(krel) code. This change improves the reusability ofkrel obs specsoutside the core Kubernetes contextThe end goal is to have a workflow similar to image promotion, but that's a long-term goal that's out of scope for alpha and beta stages.
Which issue(s) this PR fixes:
Fixes #3049
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/assign @saschagrunert @cpanato
cc @kubernetes/release-engineering