Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use systemd cgroup driver for 1.6 on CentOS/RHEL 7. #313

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Use systemd cgroup driver for 1.6 on CentOS/RHEL 7. #313

merged 1 commit into from
Apr 26, 2017

Conversation

dgoodwin
Copy link
Contributor

Fixes: #306

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 19, 2017
@mikedanese mikedanese merged commit eaeb8f8 into kubernetes:master Apr 26, 2017
sbezverk
sbezverk reviewed Apr 26, 2017
View reviewed changes
Copy link

@sbezverk sbezverk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will break Ubuntu. by default Ubuntu's docker does not use system as a cgroup driver. Ideally, kubeadm should get that info from the docker and use it in kubelet command line.

@mikedanese
Copy link
Member

@sbezverk this change is only reflected in the yum package.

@dgoodwin dgoodwin deleted the cgroup-driver-16 branch April 27, 2017 11:31
@martinpitt martinpitt mentioned this pull request May 8, 2017
Closed
martinpitt added a commit to mvollmer/cockpit that referenced this pull request May 8, 2017
@martinpitt
test: Work around kubelet.service startup failure in Fedora 26
0a91f4d 
kubelet.service fails to start out of the box:

    kubelet[1650]: Error: failed to run Kubelet: failed to create
    kubelet: misconfiguration: kubelet cgroup driver: "cgroupfs" is
    different from docker cgroup driver: "systemd"

due to kubernetes/kubernetes#43805. Add a hack
until the upstream fix (kubernetes/release#313)
trickles down into Fedora-26.
martinpitt added a commit to cockpit-project/cockpit that referenced this pull request May 8, 2017
@martinpitt
test: Work around kubelet.service startup failure in Fedora 26
fe58855 
kubelet.service fails to start out of the box:

    kubelet[1650]: Error: failed to run Kubelet: failed to create
    kubelet: misconfiguration: kubelet cgroup driver: "cgroupfs" is
    different from docker cgroup driver: "systemd"

due to kubernetes/kubernetes#43805. Add a hack
until the upstream fix (kubernetes/release#313)
trickles down into Fedora-26.
marpaia pushed a commit to marpaia/release that referenced this pull request Feb 21, 2019
@k8s-ci-robot
Merge pull request kubernetes#313 from cjwagner/tide-table
638389b 
Update Test-Infra role handbook with instructions for Tide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbezverk sbezverk sbezverk left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dgoodwin @mikedanese @sbezverk @k8s-ci-robot