build go1.21 images with base debian bookworm #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/release-eng
Signed-off-by: cpanato <ctadeu@gmail.com>
|
/test pull-release-image-kubepkg |
|
/test pull-release-image-releng-ci |
|
/test pull-release-image-go-runner |
|
/test pull-release-image-k8s-ci-builder |
|
/test pull-release-image-kube-cross |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/test pull-release-image-kubepkg |
|
/test pull-release-image-kubepkg |
|
/test pull-release-image-go-runner |
|
/test pull-release-image-k8s-ci-builder |
|
/test pull-release-image-releng-ci |
|
/test pull-release-image-kube-cross |
1 similar comment
|
/test pull-release-image-kube-cross |
36 tasks
akhilerm
added a commit
to akhilerm/publishing-bot
that referenced
this pull request
Aug 31, 2023
set CGO_ENABLED=0, so that static binaries are generated for the various publishing-bot components. This is needed because, when the build image `gcr.io/k8s-staging-releng/k8s-ci-builder:latest-default` was upgraded from bullseye to bookworm (kubernetes/release#3212), glibc version incompatibility occurred between the build machine and the prod cluster, preventing the bot from starting up. Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
akhilerm
added a commit
to akhilerm/publishing-bot
that referenced
this pull request
Aug 31, 2023
- set CGO_ENABLED=0, so that static binaries are generated for the various publishing-bot components. This is needed because, when the build image `gcr.io/k8s-staging-releng/k8s-ci-builder:latest-default` was upgraded from bullseye to bookworm (kubernetes/release#3212), glibc version incompatibility occurred between the build machine and the prod cluster, preventing the bot from starting up. - remove GO111MODULE=on, since in the latest versions of go that is used for building the bot, go modules are used by default. Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
/hold
/assign @saschagrunert @ameukam @Verolop @palnabarun
cc @kubernetes/release-managers @liggitt
Which issue(s) this PR fixes:
Related to #3076
Special notes for your reviewer:
Does this PR introduce a user-facing change?