Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-notes check subcommand #3406

Merged
merged 5 commits into from
Jan 4, 2024
Merged

release-notes check subcommand #3406

merged 5 commits into from
Jan 4, 2024

Commits on Jan 4, 2024

  1. Move generate CLI logic to subcommand 

    Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
    @puerco
    puerco committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e34d79c View commit details
    Browse the repository at this point in the history

  2. Make release-notes generate the default subcommand 

    This commit adds a new subcommand to make the `generate` subcommand the
default when running the binary without a subcommand. This avoids breaking
compatibility with previous versions.

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
    @puerco
    puerco committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    7958fab View commit details
    Browse the repository at this point in the history

  3. Add ReleaseNoteForPullRequest function 

    This commit adds a function that returns the release note of a pull request.

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
    @puerco
    puerco committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    5a81545 View commit details
    Browse the repository at this point in the history

  4. Add test for TestReleaseNoteForPullRequest 

    Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
    @puerco
    puerco committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    3812222 View commit details
    Browse the repository at this point in the history

  5. Add release-notes check subcommand 

    This commit adds a new "check" subcommand to the release-notes
utility.  This subcommand reads a PR from the github API and
check if it has a valid release note. If not it exits non-zero.

It is designed to easily add a PR check in CI to enforce authors
to add release notes.

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
    @puerco
    puerco committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    6978250 View commit details
    Browse the repository at this point in the history