Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync release-engineering-reviewers with k/release #2110

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Sync release-engineering-reviewers with k/release #2110

merged 1 commit into from
Dec 7, 2022

Conversation

saschagrunert
Copy link
Member

What type of PR is this:

/kind documentation

What this PR does / why we need it:

Follow-up on kubernetes/release#2773

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

cc @kubernetes/sig-release-admins

@saschagrunert
Sync release-engineering-reviewers with k/release
d5438aa 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2022
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Dec 7, 2022
@k8s-ci-robot k8s-ci-robot added needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2022
@saschagrunert saschagrunert changed the title Sync release-engineering-reviewers with k/release Sync release-engineering-reviewers with k/release Dec 7, 2022
cpanato
cpanato approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7181868 into kubernetes:master Dec 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Dec 7, 2022
@saschagrunert saschagrunert deleted the release-engineering-reviewers branch December 7, 2022 14:47
@justaugustus justaugustus mentioned this pull request Dec 7, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @k8s-ci-robot @cpanato