Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GOPATH/bin to PATH for enhancements verify job #11150

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Feb 6, 2019

Ref: #11126 (comment)

This occurs due to #9469.

@BenTheElder is this the right way to mitigate the $GOPATH/bin error?

/cc @justaugustus
/assign @BenTheElder
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 6, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/pm sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 6, 2019
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 17bd6b12fd6cc1dbf0c60c627e258a8572a08e28

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1c46277 into kubernetes:master Feb 6, 2019
@k8s-ci-robot
Copy link
Contributor

@nikhita: Updated the job-config configmap using the following files:

  • key enhancements-presubmit.yaml using file config/jobs/kubernetes/enhancements/enhancements-presubmit.yaml

In response to this:

Ref: #11126 (comment)

This occurs due to #9469.

@BenTheElder is this the right way to mitigate the $GOPATH/bin error?

/cc @justaugustus
/assign @BenTheElder
/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita
Copy link
Member Author

nikhita commented Feb 6, 2019

https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/enhancements/726/pull-enhancements-verify/8

{"component":"entrypoint","error":"could not start the process: fork/exec export PATH=$PATH:$GOPATH/bin: no such file or directory","level":"error","msg":"Error executing test process","time":"2019-02-06T15:36:41Z"}

@@ -7,4 +7,5 @@ presubmits:
containers:
- image: golang:1.11
command:
- export PATH=$PATH:$GOPATH/bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export is a shell command, this has to be something like:

command:
- sh
- c
- "export PATH=$PATH:$GOPATH/bin && ./hack/verify.sh"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, just move it into the verify script?

@nikhita nikhita deleted the fix-enhancements-verify branch February 19, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants