Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default kubelet flags used in windows jobs target k/k master #24934

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Jan 20, 2022

Signed-off-by: Mark Rossetti marosset@microsoft.com

--aksengine-orchestratorRelease is used to control default values used in aks-engine.
Several kubelet flags were recently removed which is causing issues during cluster bring-up for Windows jobs so we need to update the default flags set by aks-engine for these jobs.

x-ref: Azure/aks-engine#4813

fixes kubernetes/kubernetes#107641

/sig windows
/assign @jsturtevant @chewong

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Jan 20, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 20, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
@jsturtevant
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a285bb7 into kubernetes:master Jan 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 20, 2022
@k8s-ci-robot
Copy link
Contributor

@marosset: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-master-windows-presubmits.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-master-windows-presubmits.yaml
  • key release-master-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-master-windows.yaml
  • key sig-windows-containerd-hyperv.yaml using file config/jobs/kubernetes-sigs/sig-windows/sig-windows-containerd-hyperv.yaml
  • key sig-windows-sac.yaml using file config/jobs/kubernetes-sigs/sig-windows/sig-windows-sac.yaml

In response to this:

Signed-off-by: Mark Rossetti marosset@microsoft.com

--aksengine-orchestratorRelease is used to control default values used in aks-engine.
Several kubelet flags were recently removed which is causing issues during cluster bring-up for Windows jobs so we need to update the default flags set by aks-engine for these jobs.

x-ref: Azure/aks-engine#4813

fixes kubernetes/kubernetes#107641

/sig windows
/assign @jsturtevant @chewong

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing test] aks-engine-windows-containerd-master
4 participants