Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing cluster provisioning for aks-engine dualstack jobs after some dockershim flags were removed #24964

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Fixing cluster provisioning for aks-engine dualstack jobs after some dockershim flags were removed #24964

merged 1 commit into from
Jan 21, 2022

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Jan 21, 2022 •
edited
Loading

Signed-off-by: Mark Rossetti marosset@microsoft.com

We had to make the same changes for Windows.

Aks-engine changes: Azure/aks-engine#4813 and Azure/aks-engine#4817
Windows test-infra changes: #24934

@marosset
Fixing cluster provisioning for aks-engine dualstack jobs after some …
1efa42c 
…dockershim flags were removed

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2022
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 21, 2022
@marosset
Copy link
Contributor Author

/cc @chewong @aramase @jsturtevant

aramase
aramase reviewed Jan 21, 2022
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @MrHohn

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2022
MrHohn
MrHohn approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 26e57a2 into kubernetes:master Jan 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 21, 2022
@k8s-ci-robot
Copy link
Contributor

@marosset: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key dualstack-e2e.yaml using file config/jobs/kubernetes/sig-network/dualstack-e2e.yaml

In response to this:

Signed-off-by: Mark Rossetti marosset@microsoft.com

We had to make the same changes for Windows.

Aks-engine changes: Azure/aks-engine#4813 and Azure/aks-engine#4817
Windows test-infra changes: #24934

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marosset marosset deleted the aks-engine-dual-stack-dockershim-removal-files branch January 21, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase left review comments

@MrHohn MrHohn MrHohn approved these changes

@aojea aojea Awaiting requested review from aojea

@cadmuxe cadmuxe Awaiting requested review from cadmuxe

@chewong chewong Awaiting requested review from chewong

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@MrHohn MrHohn

@aramase aramase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@marosset @k8s-ci-robot @MrHohn @aramase