Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a dedicated job for testing vac feature #31717

Merged
merged 2 commits into from
Feb 27, 2024
Merged

add a dedicated job for testing vac feature #31717

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
394d2ec
add a dedicated job for testing vac feature
carlory Jan 25, 2024
e9853a7
Update config/jobs/kubernetes/sig-storage/sig-storage-kind.yaml
carlory Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 93 additions & 0 deletions config/jobs/kubernetes/sig-storage/sig-storage-kind.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,52 @@ presubmits:
cpu: "2"
memory: "6Gi"

# This jobs runs e2e.test with a focus on tests for all alpha storage features on a kind cluster
- name: pull-kubernetes-e2e-storage-kind-alpha-features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean even for a change without alpha feature change, it will still run to make sure the PR does not break our alpha changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It need be triggered manually by PR author via /test pull-kubernetes-e2e-storage-kind-alpha-features command. I'm not sure whether it should be run automatically when PR is created or not. cc @pohly i.e.

always_run: true
optional: true

There's a periodic job ci-kubernetes-e2e-storage-kind-alpha-features that runs this test periodically.

Once the feature is GA, we can drop \[Feature:VolumeAttributesClass\] from the FOCUS env.

always_run: false
optional: true
decorate: true
path_alias: k8s.io/kubernetes
cluster: eks-prow-build-cluster
skip_branches:
- release-\d+\.\d+
annotations:
testgrid-dashboards: presubmits-kubernetes-nonblocking
testgrid-tab-name: pull-kubernetes-e2e-storage-kind-alpha-features
testgrid-alert-email: kubernetes-sig-storage-test-failures@googlegroups.com
description: Run storage tests for alpha features in a KIND cluster.
labels:
preset-service-account: "true"
preset-dind-enabled: "true"
preset-kind-volume-mounts: "true"
spec:
containers:
- image: gcr.io/k8s-staging-test-infra/krte:v20240111-cf1d81388e-master
command:
- wrapper.sh
- bash
- -c
- curl -sSL https://kind.sigs.k8s.io/dl/latest/linux-amd64.tgz | tar xvfz - -C "${PATH%%:*}/" && e2e-k8s.sh
env:
- name: FEATURE_GATES
value: '{"VolumeAttributesClass":true}'
- name: RUNTIME_CONFIG
value: '{"api/ga":"true", "storage.k8s.io/v1alpha1":"true"}'
- name: FOCUS
value: \[Feature:VolumeAttributesClass\]
carlory marked this conversation as resolved.
Show resolved Hide resolved
- name: PARALLEL
value: "true"
# we need privileged mode in order to do docker in docker
securityContext:
privileged: true
resources:
requests:
cpu: "2"
memory: "6Gi"
limits:
cpu: "2"
memory: "6Gi"

periodics:
# This jobs runs storage tests that need Kubernetes In Docker (kind).
- name: ci-kubernetes-e2e-storage-kind-disruptive
Expand Down Expand Up @@ -100,3 +146,50 @@ periodics:
limits:
cpu: "2"
memory: "6Gi"

# This jobs runs e2e.test with a focus on tests for all alpha storage features on a kind cluster
- name: ci-kubernetes-e2e-storage-kind-alpha-features
interval: 12h
annotations:
testgrid-dashboards: sig-storage-kubernetes
testgrid-tab-name: kind-alpha-features
testgrid-alert-email: kubernetes-sig-storage-test-failures@googlegroups.com
description: Run storage tests for alpha features in a KIND cluster.
decorate: true
extra_refs:
- org: kubernetes
repo: kubernetes
base_ref: master
path_alias: k8s.io/kubernetes
cluster: eks-prow-build-cluster
labels:
preset-service-account: "true"
preset-dind-enabled: "true"
preset-kind-volume-mounts: "true"
spec:
containers:
- image: gcr.io/k8s-staging-test-infra/krte:v20240111-cf1d81388e-master
command:
- wrapper.sh
- bash
- -c
- curl -sSL https://kind.sigs.k8s.io/dl/latest/linux-amd64.tgz | tar xvfz - -C "${PATH%%:*}/" && e2e-k8s.sh
carlory marked this conversation as resolved.
Show resolved Hide resolved
env:
- name: FEATURE_GATES
value: '{"VolumeAttributesClass":true}'
- name: RUNTIME_CONFIG
value: '{"api/ga":"true", "storage.k8s.io/v1alpha1":"true"}'
- name: FOCUS
value: \[Feature:VolumeAttributesClass\]
- name: PARALLEL
value: "true"
# we need privileged mode in order to do docker in docker
securityContext:
privileged: true
resources:
requests:
cpu: "2"
memory: "6Gi"
limits:
cpu: "2"
memory: "6Gi"