Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misleading annotation for aws internal load balancer #15771

Closed
fbreckle opened this issue Aug 9, 2019 · 2 comments · Fixed by #15851
Closed

misleading annotation for aws internal load balancer #15771

fbreckle opened this issue Aug 9, 2019 · 2 comments · Fixed by #15851
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@fbreckle
Copy link

fbreckle commented Aug 9, 2019

Problem:
The annotation for internal load balancers on AWS has the value 0.0.0.0/0 for no apparent reason. A cidr range is not required nor supported as a value in this annotation. This is quite confusing.

The implementation at aws.go makes internal load balancers for every value except "false", so "true" has the same effect as 0.0.0.0/0 but is much more intuitive.

Proposed Solution:
Change
service.beta.kubernetes.io/aws-load-balancer-internal: 0.0.0.0/0 to service.beta.kubernetes.io/aws-load-balancer-internal: "true"

Due to the CLA, I cannot create a merge request myself.

Page to Update:
https://kubernetes.io/docs/concepts/services-networking/service/#internal-load-balancer

@thecrudge
Copy link
Contributor

thecrudge commented Aug 10, 2019

/good-first-issue

Ref #15576 - May need to speak about this, and others like it, in reference to this ticket.

@k8s-ci-robot
Copy link
Contributor

@thecrudge:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Ref #15576

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants