misleading annotation for aws internal load balancer #15771
Labels
good first issue
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Problem:
The annotation for internal load balancers on AWS has the value 0.0.0.0/0 for no apparent reason. A cidr range is not required nor supported as a value in this annotation. This is quite confusing.
The implementation at aws.go makes internal load balancers for every value except "false", so "true" has the same effect as 0.0.0.0/0 but is much more intuitive.
Proposed Solution:
Change
service.beta.kubernetes.io/aws-load-balancer-internal: 0.0.0.0/0
toservice.beta.kubernetes.io/aws-load-balancer-internal: "true"
Due to the CLA, I cannot create a merge request myself.
Page to Update:
https://kubernetes.io/docs/concepts/services-networking/service/#internal-load-balancer
The text was updated successfully, but these errors were encountered: