Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/tasks/service-catalog/install-service-catalog-using-sc/ #22008

Closed
ingenthr opened this issue Jun 23, 2020 · 10 comments
Closed
Labels
language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@ingenthr
Copy link

This is a Bug Report

Problem:

After getting "sc" tool, I then had to install cfssl and cfssljson. Those dependencies aren't listed. Chances are they were just already installed on the author's machine. It will fail thusly:

$ sc check
Dependency check failed
Error: cfssl,cfssljson commands not found in the PATH

Proposed Solution:

Page to Update:
Update the page to include these dependencies and commands.

$ go get -u github.com/cloudflare/cfssl/cmd/cfssl
$ go get -u github.com/cloudflare/cfssl/cmd/cfssljson
@sftim
Copy link
Contributor

sftim commented Jun 23, 2020

I'm not sure whether or not https://kubernetes.io/docs/tasks/service-catalog/install-service-catalog-using-sc/ should stay given that #20232 is cleaning up third party content, and sc is fairly closely tied to GCP.

My gut feeling based on #13017, the content guide, and doc-policies-for-third-party-content is that https://k8s.io/docs/tasks/service-catalog/install-service-catalog-using-sc/ should go.

It's OK to link from https://k8s.io/ to a page that explains how to use sc to set up the Service Catalog extensions, and it's fine to bring that target page up to date.

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 23, 2020
@sftim
Copy link
Contributor

sftim commented Jun 24, 2020

I'm decided. https://kubernetes.io/docs/tasks/service-catalog/install-service-catalog-using-sc/ should go.
@ingenthr this might not be quite what you'd hoped for - sorry!

@ingenthr
Copy link
Author

Thanks for the update. The only thing I'm confused by is you said "sc is fairly closely tied to GCP". We've been using service brokers and service catalog as something neutral and I did come across docs that indicate GCP has deprecated service catalog.

In any case, I respect your change/decision. I'm just trying to fit Service Brokers and Service Catalog into whether or not it's something one should rely on. I know you can't answer that question though. :)

@sftim
Copy link
Contributor

sftim commented Jul 19, 2020

Installing Service Catalog? Fine. Installing it with sc? Problematic, because sc is fairly closely tied to GCP. See issue #13017.

@sftim
Copy link
Contributor

sftim commented Jul 19, 2020

I'd be happy to see a replacement page go up that doesn't mention sc at all but does cover how to set up Service Catalog, talk OSBAPI, try it out, etc.

@ingenthr
Copy link
Author

Oh, I see! Thanks for the clarification.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 19, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 18, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants