Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Umbrella issue: third party content #20232

Closed
zacharysarah opened this issue Apr 10, 2020 · 34 comments
Closed

Umbrella issue: third party content #20232

zacharysarah opened this issue Apr 10, 2020 · 34 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@zacharysarah
Copy link
Contributor

zacharysarah commented Apr 10, 2020 •
edited
Loading

This issue replaces #15704, with gratitude to @aimeeu for her work.

Updates

UPDATE 1: Removal process updated for 1.20 and subsequent releases

What is third party content?

From the related KEP for third party content:

Third party content is content by or about a third party provider.

Our goal is to minimize and eliminate third-party content except when necessary for Kubernetes
to function in-project.

"In project" means software in the Kubernetes org, which includes the kubernetes and kubernetes-sigs repositories.

Requirements for including third party content

With the KEP for third party content merged, it's time to remove third party content from the docs unless it meets community guidelines.

Guidelines for third party content are published at https://k8s.io/docs/contribute/style/content-guide/#what-s-allowed. To summarize:

Kubernetes requires some third party content to function. Examples include container runtimes (containerd, CRI-O, Docker), networking policy (CNI plugins), Ingress controllers, and logging.

Docs can link to third-party open source software (OSS) outside the Kubernetes project if it’s necessary for Kubernetes to function.

Removing third party content in 1.20 and later releases

Follow these guidelines for PRs that remove third party content:

  • Link to this issue in the PR description.

  • Notify the relevant SIGs and stakeholders.

    • Use the relevant kubernetes/sig-foo-pr-reviews alias(es) to affected SIGs.
    • Notify other stakeholders where possible and practical.
@zacharysarah zacharysarah mentioned this issue Apr 10, 2020
Closed
10 tasks
@zacharysarah
Copy link
Contributor Author

/priority important-soon

/sig steering
/sig architecture
/sig docs

/milestone 1.19

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the 1.19 milestone Apr 10, 2020
@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Apr 10, 2020
@k8s-ci-robot
Copy link
Contributor

@zacharysarah: The label(s) sig/steering cannot be applied, because the repository doesn't have them

In response to this:

/priority important-soon

/sig steering
/sig architecture
/sig docs

/milestone 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 10, 2020
@zacharysarah
Copy link
Contributor Author

/cc @jimangel @kbarnard10 @onlydole @savitharaghunathan

@sftim sftim mentioned this issue Apr 11, 2020
Closed
This was referenced May 23, 2020
Closed
Merged
This was referenced May 30, 2020
Merged
Merged
@sftim sftim mentioned this issue Jun 2, 2020
Merged
@sftim
Copy link
Contributor

sftim commented Jun 3, 2020

Is https://kubernetes.io/docs/tasks/access-application-cluster/configure-cloud-provider-firewall/ also a candidate for removal?

@zacharysarah
Copy link
Contributor Author

@sftim

Is https://kubernetes.io/docs/tasks/access-application-cluster/configure-cloud-provider-firewall/ also a candidate for removal?

Yes. 👍

This was referenced Jun 3, 2020
Merged
Closed
@kbhawkey kbhawkey mentioned this issue Jun 4, 2020
Closed
@sftim sftim mentioned this issue Jun 7, 2020
Closed
This was referenced Jun 10, 2020
Closed
Closed
Merged
Closed
This was referenced Jun 13, 2020
Merged
Closed
This was referenced Jun 23, 2020
Closed
Closed
@sftim
Copy link
Contributor

sftim commented Jul 3, 2020

Also see #22285

@sftim sftim mentioned this issue Jul 4, 2020
Merged
This was referenced May 29, 2021
Merged
Merged
k8s-ci-robot pushed a commit that referenced this issue Jun 12, 2021
@brendandburns
Remove Google SDK instructions. (#28165)
2a03dde 
* Remove Google SDK instructions.

Ref: #20232

* Remove Google SDK instructions for MacOS

* Remove Google SDK instructions for Windows

* Delete install-kubectl-gcloud.md
@sftim sftim mentioned this issue Jun 22, 2021
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 7, 2021
@sftim
Copy link
Contributor

sftim commented Aug 1, 2021

/remove-priority important-soon
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 1, 2021
@sftim
Copy link
Contributor

sftim commented Aug 1, 2021

(it's clear that we didn't staff any remaining work on this well enough to achieve it “soon”)

@sftim sftim removed this from the 1.22 milestone Aug 1, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 1, 2021
@reylejano
Copy link
Member

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 1, 2021
@sftim sftim mentioned this issue Sep 13, 2021
Closed
@sftim
Copy link
Contributor

sftim commented Sep 13, 2021

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Sep 13, 2021
@ixodie ixodie mentioned this issue Sep 13, 2021
Merged
@sftim sftim mentioned this issue Sep 14, 2021
Merged
@ixodie ixodie mentioned this issue Sep 14, 2021
Closed
@raelga raelga mentioned this issue Sep 20, 2021
Merged
@Kumm-Kai Kumm-Kai mentioned this issue Oct 13, 2021
Closed
@jimangel jimangel mentioned this issue Dec 6, 2021
Closed
@sftim
Copy link
Contributor

sftim commented Sep 23, 2022

#36983 is part of this issue.

@sftim sftim mentioned this issue Dec 19, 2022
Merged
@tengqm
Copy link
Contributor

tengqm commented Oct 2, 2023

I'd suggest we close this one since the huge wave of this cleanup has long passed.
We still have some 3rd party contents floating around, but it is not big issue any more.
We can file individual issues & resolve them one by one.

Feel free to reopen if people still feel this one should persists.

/close

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closing this issue.

In response to this:

I'd suggest we close this one since the huge wave of this cleanup has long passed.
We still have some 3rd party contents floating around, but it is not big issue any more.
We can file individual issues & resolve them one by one.

Feel free to reopen if people still feel this one should persists.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Docs Longterm issues
Status: Done
Milestone
No milestone
Development

No branches or pull requests