Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize Kubernetes website into Arabic #44682

Open
13 of 16 tasks
seokho-son opened this issue Jan 9, 2024 · 26 comments
Open
13 of 16 tasks

Localize Kubernetes website into Arabic #44682

seokho-son opened this issue Jan 9, 2024 · 26 comments
Labels
area/localization General issues or PRs related to localization kind/feature Categorizes issue or PR as related to a new feature. language/ar Issues or PRs related to Arabic language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@seokho-son
Copy link
Member

seokho-son commented Jan 9, 2024

This is a Feature Request

Initial minimum-viable Arabic localization.

What would you like to be added

Hope to add the first live version of Arabic localization for k8s.io
This issue is to (re)initiate Arabic localization efforts based on following actionable items.

Actionable items identified from https://kubernetes.io/docs/contribute/localization/#start-a-new-localization


/language ar

@seokho-son seokho-son added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 9, 2024
@k8s-ci-robot k8s-ci-robot added language/ar Issues or PRs related to Arabic language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2024
@dipesh-rawat
Copy link
Member

/area localization

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Jan 9, 2024
@sftim
Copy link
Contributor

sftim commented Jan 9, 2024

/retitle Localize Kubernetes website into Arabic

@k8s-ci-robot k8s-ci-robot changed the title (re)Initiation of Arabic localization with actionable checklist Localize Kubernetes website into Arabic Jan 9, 2024
@sftim
Copy link
Contributor

sftim commented Jan 9, 2024

@seokho-son we typically ask for at least draft PRs before we'd make a localization branch. This cuts down the effort to maintain branches if it turns out that the localization team doesn't sustain the work.

@sftim
Copy link
Contributor

sftim commented Jan 9, 2024

(you can change the target branch of a PR after it's opened, so the draft PRs can turn into real PRs once the branch is made).

@seokho-son
Copy link
Member Author

Note: Current Status of Arabic Localization

There is a stalled issue regarding Arabic localization, #37546. I opened this issue to assist Arabic contributors in reinitiating (or making a fresh start on) contributions, focusing solely on establishing the first live version.

Additionally, there have been several attempts by various contributors in the past, but these were neither completed nor sustained.
https://github.com/kubernetes/website/pulls?q=is%3Apr+label%3Alanguage%2Far

I assume it's challenging to continue with the previous draft PRs, considering their age and the uncertainty about whether the original contributors are still willing to continue.

SIG-Docs localization subproject has recently requested assistance from some individuals to help with the initiation. I hope to use this issue to assist Arabic contributors build a team and their localization environment. I plan to invite contributors who are eager to help establish the first live version of Arabic localization and to identify potential reviewer and approver candidates.

@sftim
Copy link
Contributor

sftim commented Jan 9, 2024

If folk want advice on what those initial pull requests might look like, please reply here. We can link you up to people who can offer help.

@seokho-son
Copy link
Member Author

@seokho-son we typically ask for at least draft PRs before we'd make a localization branch. This cuts down the effort to maintain branches if it turns out that the localization team doesn't sustain the work.

Hello @sftim, thank you for sharing this information. Indeed, we typically ask for at least draft PRs to the main branch before we'd make a localization branch.

While creating this issue, I looked through https://kubernetes.io/docs/contribute/localization/#start-a-new-localization and listed only the actionable tasks based on this guide. However, it seems that creating draft PRs targeting the main branch is not included in the guide. (Perhaps, updating the guide might be necessary if required.)

However, whereas creating draft PRs can help in managing dev branches, it also tends to create a slightly complex situation for teams starting their first contributions. Additionally, opening PRs targeting main can be inconvenient, as we cannot merge interim work if everything in a single PR is not perfectly completed. If there are several draft PRs (PRs to configure localization, PRs to cover minimum-required-contents, ..), contributors are hard to check preview from each PR since base localization configuration cannot be merged into the main without minimum-required-contents.

Considering that several previous attempts have also not overcome this hurdle, how about we start by creating a dev branch first this time?

@sftim
Copy link
Contributor

sftim commented Jan 9, 2024

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2024
@seokho-son
Copy link
Member Author

SIG-Docs localization subgroup leads (myself, @a-mccarthy) are going to help alongside Arabic contributors this time and complete the tasks in the issue.


Hi folks! I've compiled this list from issues and PRs related to Arabic localization. I hope you are willing to help with this (re)initiation effort for Arabic!

@adowair
@mboukhalfa
@mhamdisemah
@mohamedsgap
@nofalx
@essamgouda97

Additionally, any contributors interested in helping with this issue, please let us know.

@seokho-son
Copy link
Member Author

Please utilize the dev-1.29-ar.1 as the base branch for initiating Arabic localization.

@seokho-son
Copy link
Member Author

Working on setting up Netlify for dev-1.29-ar.1

@adowair
Copy link

adowair commented Jan 18, 2024

✅ Signing myself up to be an active contributor to this initiative. I am not yet a Kubernetes organization member.

@essamgouda97
Copy link

I would like to be an active contributor for Arabic translation. I am not yet a k8s org member.

@seifrajhi
Copy link
Member

Additionally, any contributors interested in helping with this issue, please let us know.

Count me in please! I'm keen to contribute to the Arabic translation efforts.

@seokho-son
Copy link
Member Author

seokho-son commented Jan 31, 2024

Hello @adowair, @essamgouda97, @seifrajhi, and @mboukhalfa (I'm awaiting @mboukhalfa's participation in this discussion. Please leave a comment below.),
Thank you for your commitment to actively contributing to the Arabic team. 😊

When submitting a PR, please reference this Issue to help us effectively monitor our progress.

Also, who is interested in serving as a reviewer or an approver for Arabic? It's important to note that not all contributors are required to take on these roles, as they come with significant responsibilities. You can learn more about these roles here: Reviewers. Approvers

You can apply for both roles, but remember that the fast track is only available during the initial phase of introducing a new language. Generally, being a reviewer or an approver involves a considerable time commitment.

If you're interested in either role, please start by reviewing the Arabic content in the above PRs. Leave a comment (ex: LGTM for Arabic) if you are satisfied with Arabic content within the PR.
We will consider reviewer/approver candidates based on their review and contribution activities.

@seokho-son
Copy link
Member Author

Hi @mboukhalfa

@seifrajhi
Copy link
Member

I reviewed this PR 44698 and it is now merged 🎉

@adowair
Copy link

adowair commented Mar 13, 2024

Nominated Approvers and Reviewers

To achieve Step 5 above:

  1. Invite candidates for @kubernetes/sig-docs-ar-owners and @kubernetes/sig-docs-ar-reviews

From our last team meeting March 13th, 2024 (minutes):

Nominated Reviewers:

Nominated Approvers:

@AbdelatifAitBara
Copy link
Contributor

Hi @seokho-son,

Is there anything I can help with? I am a native Arabic Speaker.
Regards.

@adowair
Copy link

adowair commented Apr 21, 2024

Hello @AbdelatifAitBara, thanks for joining the thread! Yes, there's a lot to help with

I see you've already joined the Slack channel. We have meetings every Wednesday at 17:00 GMT (Calendar Event, Zoom, Minutes, Recordings), and it'd be great for you to join us there to get started.

Welcome aboard!

@AbdelatifAitBara
Copy link
Contributor

Thank you for all information @adowair 🥇

@adowair
Copy link

adowair commented Apr 28, 2024

@seokho-son I believe steps 6, 7, and 8 are now complete, so we can check them off above 😄

  1. @mboukhalfa, @seifrajhi, and @adowair are org members
    @essamgouda97 @AbdelatifAitBara are contributing and hope to be members soon
  2. The branch dev-1.29-ar.1 exists
  3. Add configuration block for Arabic to hugo.toml #44731
    Localize home/supported-doc-versions.md to Arabic #44698
    Create OWNERS for ar localization #45793 [ar] Add mboukhalfa as owner for arabic content #45541 Add adowair as owner, reviewer for Arabic content #45815

@mboukhalfa
Copy link
Member

@seokho-son step 8 ✅ Set up the OWNERS files based on the candidate list
done here #45793

@seokho-son
Copy link
Member Author

Thanks @mboukhalfa
I've checked from https://github.com/kubernetes/website/blob/dev-1.29-ar.1/OWNERS_ALIASES#L200 :)

Are there any additional reviewer or approver candidates still preparing for onboarding?

@mboukhalfa
Copy link
Member

mboukhalfa commented May 6, 2024

@essamgouda97 and @AbdelatifAitBara are progressing and planning to submit their membership requests soon!
Our team now is pretty organized we can onboard newcomers locally and nominate the potential reviewers and approvers!

@mboukhalfa
Copy link
Member

@seokho-son Can you please link this issue #37546 with the first item on step 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization kind/feature Categorizes issue or PR as related to a new feature. language/ar Issues or PRs related to Arabic language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

9 participants