Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ar] Translate setup/_index.md #44289

Closed
wants to merge 10 commits into from
Closed

[ar] Translate setup/_index.md #44289

wants to merge 10 commits into from

Conversation

essamgouda97
Copy link

@essamgouda97 essamgouda97 commented Dec 10, 2023

This PR will create a new file contents/docs/ar/setup/_index.md that is translated into arabic following the english docs.
Following the plan in this PR: #37546 more file will be picked. The base branch is currently main until a branch is created for arabic.

Copy link

linux-foundation-easycla bot commented Dec 10, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 10, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @essamgouda97!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Dec 10, 2023
Copy link

netlify bot commented Dec 10, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0369e1e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65c83aeb3f94400008db59d9
😎 Deploy Preview https://deploy-preview-44289--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@essamgouda97
Copy link
Author

/label language/ar

@k8s-ci-robot
Copy link
Contributor

@essamgouda97: The label(s) /label language/ar cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label language/ar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@essamgouda97 essamgouda97 marked this pull request as draft December 10, 2023 03:53
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 10, 2023
@essamgouda97
Copy link
Author

/language ar

@k8s-ci-robot k8s-ci-robot added the language/ar Issues or PRs related to Arabic language label Dec 10, 2023
@essamgouda97
Copy link
Author

/language en

@adowair
Copy link

adowair commented Dec 12, 2023

Thank you @essamgouda97 for this effort! I cannot seem to find a link that will show me a preview of this page. Have you been able to find it? https://deploy-preview-44289--kubernetes-io-main-staging.netlify.app/ takes us to the homepage, but I'm not able find the page of this PR manually by manipulating the URL.

Copy link

@adowair adowair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

شكراً على المشاركة @essamgouda97، أقترح إعادة صياغة الترجمة حيث أنها قريبة جداً إلى الترجمة الآلية. اقترح قراءة النص الإنجليزي كاملاً إستخراج المعاني والأهداف ومن ثم تحرير الترجمة بأسلوبك الخاص.

content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
@essamgouda97
Copy link
Author

Thank you @essamgouda97 for this effort! I cannot seem to find a link that will show me a preview of this page. Have you been able to find it? https://deploy-preview-44289--kubernetes-io-main-staging.netlify.app/ takes us to the homepage, but I'm not able find the page of this PR manually by manipulating the URL.

@adowair any idea what's missing ? How does that work anyways 😆 ?

@essamgouda97 essamgouda97 changed the base branch from main to dev-1.18-ar.1 January 26, 2024 19:14
@essamgouda97 essamgouda97 changed the base branch from dev-1.18-ar.1 to dev-1.29-ar.1 January 26, 2024 19:15
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 26, 2024
Copy link
Member

@mboukhalfa mboukhalfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here are some comments

content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
@mboukhalfa
Copy link
Member

you can squash commits and move from draft to ready for review

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@essamgouda97
Copy link
Author

essamgouda97 commented Feb 8, 2024

@mboukhalfa @adowair I want one more shot at improving the language used this weekend then I will squash and mark as Ready for review.
After that I will move on to another page.

@essamgouda97
Copy link
Author

@mboukhalfa @adowair this being my first OSS contribution ever I am bit noob-ish, I rebased off dev-1.29-ar.1 but there are files that I didn't edit that are there, is the branch not up to date with main ? My PR is ready for review I will mark it as such once I got it right.

@mboukhalfa
Copy link
Member

@mboukhalfa @adowair this being my first OSS contribution ever I am bit noob-ish, I rebased off dev-1.29-ar.1 but there are files that I didn't edit that are there, is the branch not up to date with main ? My PR is ready for review I will mark it as such once I got it right.

I cannot see what is really causing this probably you are not forking the correct branch ? fork dev-1.29-ar.1 create a branch from from it then add you changes better in a single commit if not necessary separate you commits then create a PR from that branch to dev-1.29-ar.1 upstream

@adowair
Copy link

adowair commented Feb 12, 2024

This PR is superseded by #45094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/ar Issues or PRs related to Arabic language language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants