New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cron job monitoring #10336

Merged
merged 3 commits into from Oct 3, 2018

Conversation

Projects
None yet
4 participants
@pietervogelaar
Contributor

pietervogelaar commented Sep 19, 2018

Added cron job monitoring with the Kubernetes job monitor

Added cron job monitoring
Added cron job monitoring with the Kubernetes job monitor
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 19, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot commented Sep 19, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8sio-netlify-preview-bot

This comment has been minimized.

Show comment
Hide comment
@k8sio-netlify-preview-bot

k8sio-netlify-preview-bot Sep 19, 2018

Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a17ad11

https://deploy-preview-10336--kubernetes-io-master-staging.netlify.com

Collaborator

k8sio-netlify-preview-bot commented Sep 19, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a17ad11

https://deploy-preview-10336--kubernetes-io-master-staging.netlify.com

@zparnold

This comment has been minimized.

Show comment
Hide comment
@zparnold

zparnold Oct 3, 2018

Member

Hey there! @pietervogelaar, looks like you haven't signed the CLA yet. Could I please have you do that? https://github.com/kubernetes/community/blob/master/CLA.md

Member

zparnold commented Oct 3, 2018

Hey there! @pietervogelaar, looks like you haven't signed the CLA yet. Could I please have you do that? https://github.com/kubernetes/community/blob/master/CLA.md

@pietervogelaar

This comment has been minimized.

Show comment
Hide comment
@pietervogelaar

pietervogelaar Oct 3, 2018

Contributor

@zparnold I did sign the CLA. The robot changed the label, so I think that is correct now?

Contributor

pietervogelaar commented Oct 3, 2018

@zparnold I did sign the CLA. The robot changed the label, so I think that is correct now?

@zparnold

This comment has been minimized.

Show comment
Hide comment
@zparnold

zparnold Oct 3, 2018

Member

Sweet! That it is, but can you rebase your changes on the master branch? Looks like we have a merge conflict.

Member

zparnold commented Oct 3, 2018

Sweet! That it is, but can you rebase your changes on the master branch? Looks like we have a merge conflict.

@pietervogelaar

This comment has been minimized.

Show comment
Hide comment
@pietervogelaar

pietervogelaar Oct 3, 2018

Contributor

@zparnold Okay, the merge conflict is resolved!

Contributor

pietervogelaar commented Oct 3, 2018

@zparnold Okay, the merge conflict is resolved!

@zparnold

This comment has been minimized.

Show comment
Hide comment
@zparnold

zparnold Oct 3, 2018

Member

/lgtm
/approve

Member

zparnold commented Oct 3, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot commented Oct 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8sio-netlify-preview-bot

This comment has been minimized.

Show comment
Hide comment
@k8sio-netlify-preview-bot

k8sio-netlify-preview-bot Oct 3, 2018

Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 9736647

https://deploy-preview-10336--kubernetes-io-master-staging.netlify.com

Collaborator

k8sio-netlify-preview-bot commented Oct 3, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 9736647

https://deploy-preview-10336--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot

This comment has been minimized.

Show comment
Hide comment
@k8sio-netlify-preview-bot

k8sio-netlify-preview-bot Oct 3, 2018

Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3426e38

https://deploy-preview-10336--kubernetes-io-master-staging.netlify.com

Collaborator

k8sio-netlify-preview-bot commented Oct 3, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3426e38

https://deploy-preview-10336--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot merged commit 86c0e43 into kubernetes:master Oct 3, 2018

3 checks passed

cla/linuxfoundation zparnold authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment