Update localization guidelines #10485

zacharysarah · 2018-10-03T23:51:12Z

👋 Reviews from stakeholders are welcome and encouraged! 🙇

TL,DR

This PR updates localization docs and workflows for https://kubernetes.io. It also proposes archiving language-specific repos (k/kubernetes-docs-*).

Updates

October 09

Incorporated feedback from reviewers
Lazy consensus now includes a section on team cleanup (Archive localization repositories and teams org#154)
~~Added a dependency: Clean up OWNERS* files with permissions by alias #10566, which updates k/website's top level OWNERS* and allows this PR to explicitly specify content/en/OWNERS.~~ RESOLVED

October 10

Addressed feedback from @gochist, @cstoku, @tnir, @claudiajkang
Fixed lazy consensus to read "Friday, October 12"

Summary

This PR updates several aspects of localization (l10n) for Kubernetes docs:

Localization guidelines reflect that all l10n work now happens in k/website instead of subproject repositories.
Individual content/<xx> directories gain language-specific OWNERS files. This lets translation teams review and approve their own l10n-specific PRs.
Chinese content moves from content/cn/ to content/zh/ to conform with the ISO 639-1 naming scheme.
Language-specific subproject repositories will be archived.

Context

In Q3 2017, Kubernetes SIG Docs invited an independent Chinese localization project to house their project in k/website. SIG Docs was unprepared for the introduction of Chinese-language content, due to both the amount of PRs and the lack of Chinese fluency on the part of k/website's maintainers.

To enable translation work to continue while SIG Docs solved for infrastructure support and a scalable l10n workflow, SIG Docs proposed the creation of a language-specific subproject for Chinese content (kubernetes-docs-zh). The goal was for translation work to continue without creating an undue burden on either the Chinese l10n (via a backlog of unapproved PRs) or on SIG Docs maintainers (unable to provide meaningful review of Chinese content).

SIG Architecture also approved the creation of two additional repos for new localization projects in Japanese (k/kubernetes-docs-ja) and Korean (k/kubernetes-docs-ko).

In Q3 2018, while solving for how to pass source content and translated output between repos, @zparnold proposed and implemented a language label bot. The bot automatically assigns labels to PRs based on the content/* filepaths of pull requests, allowing reviewers to filter pull requests by language. For example, see this list of PRs with Korean content.

UPDATE: Per @cblecker in #10485 (comment), Prow natively supports automatic label assignment by language. I've updated this PR accordingly. The implementation differs from the original proposal, but the strategic effect remains the same.

The combination of native multilingual support and automated language labeling allows SIG Docs to consolidate l10n workflows in a single repository: k/website. This strategy scales appropriately with increasing numbers of localizations. The alternative requires SIG Docs to enforce common standards for synchronizing source and output across multiple, non-forked repos with disparate branching structures and non-identical milestones. These strategies are unnecessarily complex and do not scale well.

Consolidating workflows is a good idea. Let's do it.

There is one notable downside of archiving language-specific repos: absent some finely-tuned git commands, l10n teams could lose their commit histories by moving files from one repo to another. This is avoidable, but it does require git expertise. (:point_left: @mistyhacks) It's also not the end of the world, but it is kind of a bummer.

Easy file previews

https://deploy-preview-10485--kubernetes-io-master-staging.netlify.com/docs/contribute/localization/

Dependencies

PRs in k/website

PR	Description	✔️
#10566	Update OWNERS* to enable `content/en/OWNERS`	✔️

Impacts to other Kubernetes SIGs

PR	SIG	Impact
kubernetes/community#2753	community	Remove language-specific subprojects from SIG Docs info
kubernetes/test-infra#9732	test-infra	Remove language-specific subproject repos from Prow configuration
kubernetes/org#154	Kubernetes org	Archive language-specific repos and teams

Lazy consensus

If stakeholders do nothing by Friday, October 12:

k8sio-netlify-preview-bot · 2018-10-03T23:56:21Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 76a9621

https://deploy-preview-10485--kubernetes-io-master-staging.netlify.com

k8sio-netlify-preview-bot · 2018-10-03T23:56:54Z

Deploy preview for kubernetes-io-master-staging failed.

Built with commit a6cf9f4

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bc10f4473f2cf64dde20c56

zacharysarah · 2018-10-07T01:50:00Z

Stakeholders

SIG Architecture

Should the Kubernetes org fork the language label app into the kubernetes GitHub organization?

@cblecker, @kubernetes/sig-architecture-pr-reviews
/sig architecture

SIG Community

@parispittman, @kubernetes/community-reviewers
/sig community

SIG Docs

@Bradamant3, @chenopis, @jaredbhatti, @zparnold
@mistyhacks for git expertise in preserving commit histories between repos

SIG Test-Infra

@spiffxp, @kubernetes/test-infra-reviewers
/sig test-infra

General interest

@caniszczyk, @dankohn

zacharysarah · 2018-10-07T01:51:29Z

config.toml

@@ -7,7 +7,7 @@ enableRobotsTXT = true

 disableKinds = ["taxonomy", "taxonomyTerm"]

-ignoreFiles = [ "^OWNERS$", "README.md", "^node_modules$", "content/en/docs/doc-contributor-tools" ]
+ignoreFiles = [ "^OWNERS$", "README*.md", "^node_modules$", "content/en/docs/doc-contributor-tools" ]


Does this regex correctly exclude examples like README-ko.md?

@zparnold

^OWNERS$ seems to copy the OWNERS file in the subdirectory. I think OWNERS$ is correct.

@cstoku Thanks--it's the addition of language-specific READMEs (for example, README-ja.md) for which I want to verify the exclusion with "README*.md".

@zparnold ☝️ PTAL

I think you want to tighten this regex. You want to match things that:

start with README

end with .md

Don't have -[a-z][a-z]

So: README\.md gets exactly README.md without any others.

If you wanted to match only the language-specific ones: README[-]+[a-z]*\.md That looks for things with 1 or more hyphen and then 0 or more letters before the .md

@mistyhacks Thanks for the review! ✨

@zacharysarah Use \\ instead of \ in a toml file, like "README[-]+[a-z]*\\.md".

gochist

I have questions

gochist · 2018-10-07T03:16:27Z

content/en/docs/contribute/localization.md


-Each l10n repository must have branches for the different Kubernetes documentation release versions, matching the branches in the main [kubernetes/website](https://github.com/kubernetes/website) documentation repository. For example, the kubernetes/website `release-1.10` branch (https://github.com/kubernetes/website/tree/release-1.10) has a corresponding branch in the kubernetes/kubernetes-docs-zh repository (https://github.com/kubernetes/kubernetes-docs-zh/tree/release-1.10). These version branches keep track of the differences in the documentation between Kubernetes versions.
+Teams are free to use any branching strategy for work in progress. For example, a German localization team might use source files from `{{< release-branch >}}`, but work in `dev-{{< release-branch >}}-de-1.0` before squashing commits in a single PR against `{{< release-branch >}}`.  


In this example, which repository does the dev-{{< release-branch >}}-de-1.0 branch belong to? If it is k/website, does l10n team have permission to create those branch?

@gochist 👋

which repository does the branch belong to?

Yes, it's k/website.

does l10n team have permission to create those branch?

Yes. 👍

It's probably best to treat a development branch for translation the same as any other long-running collaborative branch (for example, the release branches for 1.11 and 1.10: #9171, #7818).

Normally we require folks to open PRs on a fork of k/website, but for collaborative projects like localizations I think it's better to treat them like release branches and open directly against k/website.

A development branch for 1.12 source would require an open PR against https://github.com/kubernetes/website/tree/release-1.12, which Individual contributors would then use as the base for their own PRs. A team needs to agree on who opens and maintains the PR--by keeping it current with its parent branch, resolving merge conflicts, and setting expectations for when to merge it--but that can be anyone, with no special permissions required.

We should absolutely specify this in the docs. 👍 I'll update this PR accordingly. Great question! ✨

content/en/docs/contribute/localization.md

cstoku · 2018-10-07T17:29:41Z

About the overview of this issue, is the following content correct?

Now:

Add an OWNERS file to /content/ja/ that duplicates kubernetes-docs-ko:OWNERS

* [ ]  Add an OWNERS file to `/content/ja/` that duplicates [`kubernetes-docs-ko:OWNERS`](https://github.com/kubernetes/kubernetes-docs-ja/blob/master/OWNERS)

Revised:

Add an OWNERS file to /content/ja/ that duplicates kubernetes-docs-ja:OWNERS

* [ ]  Add an OWNERS file to `/content/ja/` that duplicates [`kubernetes-docs-ja:OWNERS`](https://github.com/kubernetes/kubernetes-docs-ja/blob/master/OWNERS)

Now:

Archive the kubernetes/kubernetes-docs-ja repository using admin permissions

Make one final commit of kubernetes-docs-ko:content/ja/ to k/website

Archive the kubernetes/kubernetes-docs-zh repository using admin permissions

Make one final commit of kubernetes-docs-ko:content/zh/ to k/website

* [ ]  Archive the [`kubernetes/kubernetes-docs-ja`](https://github.com/kubernetes/kubernetes-docs-ko) repository using admin permissions

  * [ ]  Make one final commit of `kubernetes-docs-ko:content/ja/` to `k/website`
* [ ]  Archive the [`kubernetes/kubernetes-docs-zh`](https://github.com/kubernetes/kubernetes-docs-ko) repository using admin permissions

  * [ ]  Make one final commit of `kubernetes-docs-ko:content/zh/` to `k/website`

Revised:

Archive the kubernetes/kubernetes-docs-ja repository using admin permissions

Make one final commit of kubernetes-docs-ja:content/ja/ to k/website

Archive the kubernetes/kubernetes-docs-zh repository using admin permissions

Make one final commit of kubernetes-docs-zh:content/zh/ to k/website

* [ ]  Archive the [`kubernetes/kubernetes-docs-ja`](https://github.com/kubernetes/kubernetes-docs-ja) repository using admin permissions

  * [ ]  Make one final commit of `kubernetes-docs-ja:content/ja/` to `k/website`
* [ ]  Archive the [`kubernetes/kubernetes-docs-zh`](https://github.com/kubernetes/kubernetes-docs-zh) repository using admin permissions

  * [ ]  Make one final commit of `kubernetes-docs-zh:content/zh/` to `k/website`

tnir · 2018-10-08T05:00:15Z

content/en/docs/contribute/localization.md

-Upstream contributions are welcome and encouraged!
-
-For the sake of efficiency, limit upstream contributions to a single pull request per week, containing a single [squashed commit](https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit).
+SIG Docs welcomes ustream contributions and corrections to the English source! For the sake of efficiency, limit upstream contributions to a single pull request per week, containing a single [squashed commit](https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit).


s/ustream/upstream/

@tnir Even editors are not immune. 😆 🙇

tnir · 2018-10-08T05:00:58Z

content/en/docs/contribute/localization.md


 ```shell
 mkdir -p content/de/docs/tutorials
-cp content/en/docs/tutorials/kubernetes-basics.md content/de/docs/tutorials/kubernetes-basics.md
+cp content/en/docs/tutorials/kubernetes-basics.md  content/de/docs/tutorials/kubernetes-basics.md


You don't need to add an extra white space here 😄

k8s-ci-robot · 2018-10-12T21:23:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbarnard10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kbarnard10]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tnir · 2018-10-12T23:11:58Z

@zacharysarah @kbarnard10 👍 🎉

While just checked zh and ko, https://kubernetes.io/zh/ is not found (404) (/cn/ is still available) and https://kubernetes.io/ko/ looks wierd (features and case studies).

zparnold · 2018-10-12T23:25:59Z

It might be a CDN cache issue

…

On Fri, Oct 12, 2018 at 4:12 PM Takuya N ***@***.***> wrote: @zacharysarah <https://github.com/zacharysarah> @kbarnard10 <https://github.com/kbarnard10> 👍 🎉 While just checked zh and ko, https://kubernetes.io/zh/ is not found (404) (/cn/ is still available) and https://kubernetes.io/ko/ looks wierd (features and case studies). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10485 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE81SOYC1Qp5zigcbwPY_MP2OJe5o4fbks5ukSHCgaJpZM4XHIwZ> .

tnir · 2018-10-13T00:09:33Z

@zparnold Thanks 😄

zacharysarah · 2018-10-15T01:44:59Z

@tnir LGTM: https://kubernetes.io/zh/

tnir · 2018-10-15T02:36:22Z

@zacharysarah Yes, after #10610 (and might be other PRs), now we can see that it works well 🎉🎉🎉

markthink · 2018-10-15T12:08:02Z

@zacharysarah I can't create a branch PUSH code for myself, I can't complete the update operation, suggesting that I didn't pass the cla check. In fact, this problem should not exist.

Counting objects: 4, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 11.18 KiB | 0 bytes/s, done.
Total 4 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 1 local object.
remote: error: GH006: Protected branch update failed for refs/heads/release-1.12-zh.
remote: error: Required status check "cla/linuxfoundation" is expected.
To https://github.com/kubernetes/kubernetes-docs-zh.git
 ! [remote rejected]   release-1.12-zh -> release-1.12-zh (protected branch hook declined)
error: failed to push some refs to 'https://github.com/kubernetes/kubernetes-docs-zh.git'

PUSH is designed to update the latest code base, and managing documents is sometimes necessary.

The impact of this issue：Although it has been successfully switched from cn to zh directory here, kubernetes-docs-zh does not push update permissions, and submitting PR operations to merge documents is not particularly convenient.

zacharysarah · 2018-10-15T17:29:15Z

@markthink Please open your comment as a new issue so we can resolve it separately. Thanks in advance.

brucehex · 2018-10-18T01:39:59Z

@zacharysarah ok, thank you.

This commit adds a link about Localizing Kubernetes Documentation in README.md's Contributing to the docs section. Fixed : kubernetes#10485, kubernetes#10622 Signed-off-by: Claudia J. Kang <claudiajkang@gmail.com>

This commit adds a link process about the l10n README files in localization.md. Fixed : kubernetes#10485, kubernetes#10622 Signed-off-by: Claudia J. Kang <claudiajkang@gmail.com>

* New link about Localizing Kubernetes Documentation This commit adds a link about Localizing Kubernetes Documentation in README.md's Contributing to the docs section. Fixed : #10485, #10622 Signed-off-by: Claudia J. Kang <claudiajkang@gmail.com> * Update l10n guide about adding l10n README files. This commit adds a link process about the l10n README files in localization.md. Fixed : #10485, #10622 Signed-off-by: Claudia J. Kang <claudiajkang@gmail.com>

* Update localization guidelines for language labels Continuing work Continuing work Continuing work More work in progress Add local OWNERS folders Add an OWNERS file to Chinese Remove shortcode for repos Add Japanese Alphabetize languages, change weights accordingly More updates Add Korean in Korean Add English to languageName Feedback from gochist Move Chinese content from cn/ to zh/ Move OWNERS from cn/ to zh/ Resolve merge conflicts by updating from master Add files back in to prep for resolution After rebase on upstream/master, remove files Review and update localization guidelines Feedback from gochist, tnir, cstoku Add a trailing newline to content/ja/OWNERS Add a trailing newline to content/zh/OWNERS Drop requirement for GH repo project Clarify language about forks/branches Edits and typos Remove a shortcode specific to a multi-repo language setup Update aliases and owners Add explicit OWNERS for content/en Migrate content from Chinese repo, update regex in config.toml Remove untranslated strings Add trailing newline to content/en/OWNERS Add trailing newlines to OWNERS files add Jaguar project description (kubernetes#10433) * add Jaguar project description [Jaguar](https://gitlab.com/sdnlab/jaguar) is an open source solution for Kubernetes's network based on OpenDaylight. Jaguar provides overlay network using vxlan and Jaguar CNIPlugin provides one IP address per pod. * Minor newline tweak blog post for azure vmss (kubernetes#10538) Add microk8s to pick-right-solution.md (kubernetes#10542) * Add microk8s to pick-right-solution.md Microk8s is a single-command installation of upstream Kubernetes on any Linux and should be included in the list of local-machine solutions. * capitalized Istio Add microk8s to foundational.md (kubernetes#10543) * Add microk8s to foundational.md Adding microk8s as credible and stable alternative to get started with Kubernetes on a local machine. This is especially attractive for those not wanting to incur the overhead of running a VM for a local cluster. * Update foundational.md Thank you for your suggestions! LMK if this works now? * Rewrote first paragraph And included a bullet list of features of microk8s * Copyedit fix typo (kubernetes#10545) Fix the kubectl subcommands links. (kubernetes#10550) Signed-off-by: William Zhang <warmchang@outlook.com> Fix command issue (kubernetes#10515) Signed-off-by: mooncake <xcoder@tenxcloud.com> remove imported community files per issue 10184 (kubernetes#10501) networking.md: Markdown fix (kubernetes#10498) Fix front matter, federation command-line tools (kubernetes#10500) Clean up glossary entry (kubernetes#10399) update slack link (kubernetes#10536) typo in StatefulSet docs (kubernetes#10558) fix discription about horizontal pod autoscale (kubernetes#10557) Remove redundant symbols (kubernetes#10556) Fix issue kubernetes#10520 (kubernetes#10554) Signed-off-by: William Zhang <warmchang@outlook.com> Update api-concepts.md (kubernetes#10534) Revert "Fix command issue (kubernetes#10515)" This reverts commit c02a7fb. Update memory-constraint-namespace.md (kubernetes#10530) update memory request to 100MiB corresponding the yaml content Blog: Introducing Volume Snapshot Alpha for Kubernetes (kubernetes#10562) * blog post for azure vmss * snapshot blog post Resolve merge conflicts in OWNERS* Minor typo fix (kubernetes#10567) Not sure what's supposed to be here, proposing removing it. * Feedback from gochist Tweaks to feedback * Feedback from ClaudiaJKang

zacharysarah self-assigned this Oct 3, 2018

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2018

kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 3, 2018

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2018

k8s-ci-robot requested review from stewart-yu and zhangxiaoyu-zidif October 3, 2018 23:51

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2018

This was referenced Oct 4, 2018

[WIP] Move Chinese language content from cn/ to zh/ #10504

Closed

Update localization subproject info kubernetes/community#2753

Merged

claudiajkang mentioned this pull request Oct 5, 2018

ONWERS under contents/ko directory kubernetes-retired/kubernetes-docs-ko#46

Closed

2 tasks

zacharysarah mentioned this pull request Oct 6, 2018

Alphabetize languages, change weights accordingly #10503

Closed

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2018

kubernetes-docs-i18n-bot added the language/zh Issues or PRs related to Chinese language label Oct 6, 2018

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 6, 2018

zacharysarah mentioned this pull request Oct 7, 2018

Remove language-specific repos from Prow kubernetes/test-infra#9732

Merged

k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Oct 7, 2018

zacharysarah changed the title ~~[WIP] Update localization guidelines~~ Update localization guidelines Oct 7, 2018

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2018

zacharysarah commented Oct 7, 2018

View reviewed changes

gochist reviewed Oct 7, 2018

View reviewed changes

tnir reviewed Oct 8, 2018

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2018

k8s-ci-robot merged commit abcee2d into kubernetes:master Oct 12, 2018

zacharysarah deleted the update-l10n-guidelines branch October 12, 2018 21:35

This was referenced Oct 13, 2018

Fail to run make serve after #10485 #10604

Closed

Fix Hugo config.toml as valid #10605

Merged

tnir mentioned this pull request Oct 13, 2018

Use hugo in Travis CI pipeline #10606

Merged

This was referenced Oct 18, 2018

Update site config for l10n teams and 1.11 info #10667

Merged

Update site config for l10n teams and 1.10 info #10668

Merged

claudiajkang mentioned this pull request Oct 18, 2018

Update l10n READMEs link #10669

Merged

zacharysarah mentioned this pull request Nov 8, 2018

Prow doesn't automatically apply language labels kubernetes/test-infra#10097

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update localization guidelines #10485

Update localization guidelines #10485

zacharysarah commented Oct 3, 2018 •

edited

k8sio-netlify-preview-bot commented Oct 3, 2018

k8sio-netlify-preview-bot commented Oct 3, 2018 •

edited

zacharysarah commented Oct 7, 2018

zacharysarah Oct 7, 2018 •

edited

cstoku Oct 7, 2018

zacharysarah Oct 8, 2018

zacharysarah Oct 8, 2018

mdlinville Oct 9, 2018 •

edited

zacharysarah Oct 9, 2018

tnir Oct 10, 2018

gochist left a comment

gochist Oct 7, 2018

zacharysarah Oct 8, 2018 •

edited

cstoku commented Oct 7, 2018 •

edited by zacharysarah

tnir Oct 8, 2018

zacharysarah Oct 8, 2018

tnir Oct 8, 2018

k8s-ci-robot commented Oct 12, 2018

tnir commented Oct 12, 2018

zparnold commented Oct 12, 2018 via email

tnir commented Oct 13, 2018

zacharysarah commented Oct 15, 2018

tnir commented Oct 15, 2018

markthink commented Oct 15, 2018 •

edited

zacharysarah commented Oct 15, 2018

brucehex commented Oct 18, 2018


		Each l10n repository must have branches for the different Kubernetes documentation release versions, matching the branches in the main [kubernetes/website](https://github.com/kubernetes/website) documentation repository. For example, the kubernetes/website `release-1.10` branch (https://github.com/kubernetes/website/tree/release-1.10) has a corresponding branch in the kubernetes/kubernetes-docs-zh repository (https://github.com/kubernetes/kubernetes-docs-zh/tree/release-1.10). These version branches keep track of the differences in the documentation between Kubernetes versions.
		Teams are free to use any branching strategy for work in progress. For example, a German localization team might use source files from `{{< release-branch >}}`, but work in `dev-{{< release-branch >}}-de-1.0` before squashing commits in a single PR against `{{< release-branch >}}`.

Update localization guidelines #10485

Update localization guidelines #10485

Conversation

zacharysarah commented Oct 3, 2018 • edited

TL,DR

Updates

October 09

October 10

Summary

Context

Easy file previews

Dependencies

PRs in k/website

Impacts to other Kubernetes SIGs

Lazy consensus

k8sio-netlify-preview-bot commented Oct 3, 2018

k8sio-netlify-preview-bot commented Oct 3, 2018 • edited

zacharysarah commented Oct 7, 2018

Stakeholders

Chinese localization

Japanese localization

Korean localization

SIG Architecture

SIG Community

SIG Docs

SIG Test-Infra

General interest

zacharysarah Oct 7, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdlinville Oct 9, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gochist left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zacharysarah Oct 8, 2018 • edited

Choose a reason for hiding this comment

cstoku commented Oct 7, 2018 • edited by zacharysarah

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 12, 2018

tnir commented Oct 12, 2018

zparnold commented Oct 12, 2018 via email

tnir commented Oct 13, 2018

zacharysarah commented Oct 15, 2018

tnir commented Oct 15, 2018

markthink commented Oct 15, 2018 • edited

zacharysarah commented Oct 15, 2018

brucehex commented Oct 18, 2018

zacharysarah commented Oct 3, 2018 •

edited

k8sio-netlify-preview-bot commented Oct 3, 2018 •

edited

zacharysarah Oct 7, 2018 •

edited

mdlinville Oct 9, 2018 •

edited

zacharysarah Oct 8, 2018 •

edited

cstoku commented Oct 7, 2018 •

edited by zacharysarah

markthink commented Oct 15, 2018 •

edited