Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hugo config.toml as valid #10605

Merged
merged 1 commit into from
Oct 13, 2018

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Oct 13, 2018

Closes #10604

Fix a regression from #10485. We can't run make serve:

$ make serve
hugo server --ignoreCache --disableFastRender
Error: While parsing config: (10, 30): invalid escape sequence: \.
make: *** [serve] Error 255

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 13, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging failed.

Built with commit e3827ef

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bc1374ab13fb10f54c05a0b

@tnir
Copy link
Contributor Author

tnir commented Oct 13, 2018

/kind bug
/cc @zacharysarah
/assign @Bradamant3
/assign @zacharysarah

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 13, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging failed.

Built with commit e3827ef

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bc1374ac6aed6713cdf2f99

@zacharysarah
Copy link
Contributor

@tnir Thanks for the fix! 🌟

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit d14b898 into kubernetes:master Oct 13, 2018
@tnir tnir deleted the 10604-valid-config-toml branch October 13, 2018 02:49
@tnir
Copy link
Contributor Author

tnir commented Oct 13, 2018

@zacharysarah Thanks. 🎉 If I remember correctly, I had pointed out this on #10485 a few days ago while we can't see it any more..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants