Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document nodeAffinity field for PersistentVolume #10617

Merged
merged 1 commit into from
Nov 22, 2018
Merged

document nodeAffinity field for PersistentVolume #10617

merged 1 commit into from
Nov 22, 2018

Conversation

rskrishnar
Copy link

@rskrishnar rskrishnar commented Oct 15, 2018 •
edited
Loading

Fixes #7900

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 15, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 15, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 15, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f9c0423

https://deploy-preview-10617--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor

tengqm commented Oct 15, 2018

/lgtm
Thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2018
@msau42
Copy link
Member

msau42 commented Oct 15, 2018 •
edited
Loading

The reason why this field was not explicitly documented is because most users do not need to explicitly set it (really only in the case of local volumes, where it's already documented). So with these changes, I want to emphasize the situations where you might need to set it, and make sure we don't confuse the users into thinking it's necessary most of the time

The storage documentation is already very confusing for new users to understand.

@msau42
Copy link
Member

msau42 commented Oct 15, 2018

/lgtm cancel

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0b68ebc

https://deploy-preview-10617--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 16, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 13a389c

https://deploy-preview-10617--kubernetes-io-master-staging.netlify.com

@rskrishnar rskrishnar force-pushed the document-nodeAffinity-field-for-PersistentVolume branch from 0b68ebc to 33393c6 Compare October 16, 2018 05:18
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2018
@zacharysarah zacharysarah added Docs Review: Open Issues size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2018
@Bradamant3
Copy link
Contributor

@rskrishnar nice work on a difficult issue. There are still some useful comments outstanding from msau -- if you could address we can get this PR merged. I agree that most if not all of the content from line 422 onward can be replaced with a link to the more general node affinity doc content.

Thanks! lmk if you have questions.

/assign

@rskrishnar rskrishnar force-pushed the document-nodeAffinity-field-for-PersistentVolume branch from b706039 to 1478285 Compare November 17, 2018 07:13
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 17, 2018
@rskrishnar rskrishnar closed this Nov 17, 2018
@rskrishnar rskrishnar reopened this Nov 17, 2018
@rskrishnar
Copy link
Author

@Bradamant3 Made the changes. I kept it simple.

msau42
msau42 reviewed Nov 20, 2018
View reviewed changes
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! lgtm, just two minor nits

content/en/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
@rskrishnar rskrishnar force-pushed the document-nodeAffinity-field-for-PersistentVolume branch from 20d32aa to 1d61c02 Compare November 20, 2018 03:52
@rskrishnar rskrishnar force-pushed the document-nodeAffinity-field-for-PersistentVolume branch from 1d61c02 to 13a389c Compare November 21, 2018 09:42
@msau42
Copy link
Member

msau42 commented Nov 21, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2018
@tengqm
Copy link
Contributor

tengqm commented Nov 22, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit f9071fd into kubernetes:master Nov 22, 2018
@rskrishnar rskrishnar deleted the document-nodeAffinity-field-for-PersistentVolume branch November 22, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@msau42 msau42 msau42 left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@tengqm tengqm

@Bradamant3 Bradamant3

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rskrishnar @k8sio-netlify-preview-bot @tengqm @msau42 @Bradamant3 @k8s-ci-robot @zacharysarah @kubernetes-docs-i18n-bot