Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-trans: add docs/getting-started-guides/ubuntu/local.md #11622

Merged
merged 3 commits into from
Dec 15, 2018
Merged

zh-trans: add docs/getting-started-guides/ubuntu/local.md #11622

merged 3 commits into from
Dec 15, 2018

Conversation

chenrui333
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2018
@netlify
Copy link

netlify bot commented Dec 7, 2018 •
edited
Loading

Deploy preview for k8s-v1-12 processing.

Built with commit de2c237

https://app.netlify.com/sites/k8s-v1-12/deploys/5c12d1476c9f8b00075e83fa

@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Dec 7, 2018
@chenrui333 chenrui333 mentioned this pull request Dec 7, 2018
Closed
@chenrui333
Copy link
Member Author

/cc @tengqm @Mr-Linus @AdamDang @xichengliudui @SataQiu

@k8s-ci-robot
Copy link
Contributor

@chenrui333: GitHub didn't allow me to request PR reviews from the following users: SataQiu, AdamDang, xichengliudui.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tengqm @Mr-Linus @AdamDang @xichengliudui @SataQiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chenrui333
Copy link
Member Author

@SataQiu please review again, thanks!

@SataQiu
Copy link
Member

SataQiu commented Dec 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2018
@SataQiu
Copy link
Member

SataQiu commented Dec 14, 2018

/cc @markthink

markthink
markthink reviewed Dec 15, 2018
View reviewed changes
Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 734d931 into kubernetes:release-1.12 Dec 15, 2018
@chenrui333 chenrui333 deleted the zh-trans/docs/getting-started-guides/ubuntu/local.md branch January 24, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markthink markthink markthink left review comments

@SataQiu SataQiu SataQiu left review comments

@idealhack idealhack Awaiting requested review from idealhack

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

@tengqm tengqm Awaiting requested review from tengqm

@Mr-Linus Mr-Linus Awaiting requested review from Mr-Linus

Assignees

@markthink markthink

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @k8s-ci-robot @SataQiu @markthink