Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh_trans: Fix homepage kubernetes feature display invalidation problem #11755

Merged
merged 4 commits into from
Dec 17, 2018
Merged

zh_trans: Fix homepage kubernetes feature display invalidation problem #11755

merged 4 commits into from
Dec 17, 2018

Conversation

Mr-Linus
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 14, 2018
@netlify
Copy link

netlify bot commented Dec 14, 2018 •
edited
Loading

Deploy preview for k8s-v1-12 processing.

Built with commit 2e88070

https://app.netlify.com/sites/k8s-v1-12/deploys/5c15b83bbdefe10007595085

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 14, 2018
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Dec 14, 2018
@Mr-Linus
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2018
@Mr-Linus Mr-Linus mentioned this pull request Dec 14, 2018
Merged
@Mr-Linus
Copy link
Contributor Author

Mr-Linus commented Dec 15, 2018 •
edited
Loading

/hold cancel

@Mr-Linus
Copy link
Contributor Author

/cc @chenrui333 @tengqm

markthink
markthink reviewed Dec 15, 2018
View reviewed changes
Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原始的英文补上吧

@Mr-Linus
Copy link
Contributor Author

@markthink 好的 已经补上了

@Mr-Linus
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2018
@markthink
Copy link

@Mr-Linus 我看只补了一小段你修改的部分，其他的中文对应的英文建议也一起更新一下..

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2018
@Mr-Linus
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2018
@chenrui333
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2018
@chenrui333
Copy link
Member

还需要 继续 /hold 么，lgtm

cc @Mr-Linus @markthink

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2018
@Mr-Linus
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2018
@Mr-Linus
Copy link
Contributor Author

cc @markthink @chenrui333 fixed .
Need LGTM again.

@chenrui333
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2018
@chenrui333
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenrui333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 43694f3 into kubernetes:release-1.12 Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markthink markthink markthink left review comments

@chenrui333 chenrui333 chenrui333 approved these changes

@tengqm tengqm Awaiting requested review from tengqm

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@chenrui333 chenrui333

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mr-Linus @markthink @chenrui333 @k8s-ci-robot