Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Contribute index page for Indonesian localization #18452

Merged
merged 5 commits into from
Jan 6, 2020
Merged

Add Contribute index page for Indonesian localization #18452

merged 5 commits into from
Jan 6, 2020

Conversation

phanama
Copy link
Contributor

@phanama phanama commented Jan 4, 2020

This PR kickstarts the index page for #18336
Requesting for proofreading.

/assign @irvifa
/assign @girikuncoro

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2020
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 4, 2020
irvifa
irvifa suggested changes Jan 4, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitty gritty feedback from me. Anyway thanks 🎉

content/id/contribute/_index.md Outdated
@@ -0,0 +1,79 @@
---
content_template: templates/concept
title: Berkontribusi ke dokumentasi Kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Berkontribusi ke dokumentasi Kubernetes
title: Berkontribusi ke Dokumentasi Kubernetes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed here 8237a38

I also added an update to a mistranslation to Open issue -> I thought this was a noun, but it's actually a verb.
Thanks @wahyuoi for pointing this out!
8237a38#diff-ffc999e20875f5664de07a3c269c7118R51

sftim
sftim requested changes Jan 4, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phanama I think the path to this new page is wrong in the repo.
I'm pleased to see the draft!

content/id/contribute/_index.md Outdated Show resolved Hide resolved
@phanama
Fix indonesian contribute docs path
73f02f1
@phanama
Changes to id contribute docs wordings
7438b2c 
- Changed noun to verb in content/id/docs/home/_index.md
- Sync wordings in content/id/docs/contribute/_index.md with content/id/docs/home/_index.md
- Wording improvement for content/id/docs/contribute/_index.md
@girikuncoro
Copy link
Contributor

Everything looks good, just need to fix 1 minor typo and you are good to go. Thanks a lot for doing this, and welcome back from holiday!

@girikuncoro
Copy link
Contributor

Thanks a lot!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 816e63a into kubernetes:master Jan 6, 2020
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@phanama @wawa0210
Add Contribute index page for Indonesian localization (kubernetes#18452)
641f4c0 
* Add Contribute index page for Indonesian localization

* Update Indonesian Contribute index

* Fix indonesian contribute docs path

* Changes to id contribute docs wordings

- Changed noun to verb in content/id/docs/home/_index.md
- Sync wordings in content/id/docs/contribute/_index.md with content/id/docs/home/_index.md
- Wording improvement for content/id/docs/contribute/_index.md

* Fix a typo in id contribute index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girikuncoro girikuncoro girikuncoro left review comments

@irvifa irvifa irvifa requested changes

@sftim sftim sftim requested changes

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phanama @girikuncoro @k8s-ci-robot @irvifa @sftim