Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove “Configure Your Cloud Provider's Firewalls” #21459

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jun 3, 2020

Remove Configure Your Cloud Provider's Firewalls as it doesn't meet the Kubernetes website
content guidelines.

Partial fix for issue #20232.

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 3, 2020
@sftim
Copy link
Contributor Author

sftim commented Jun 3, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jun 3, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 3, 2020
@netlify
Copy link

netlify bot commented Jun 3, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit fc25b8e

https://deploy-preview-21459--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor Author

sftim commented Jun 3, 2020

Relevant to issue #4495

@celestehorgan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2020
@jimangel
Copy link
Member

Kind of odd to have to resolve a conflict of a deleted file, but here we are... This looks good to merge as it has been 7 days. Feel free to ping me on slack once conflict is resolved! Thanks!

Removing this page as it doesn't meet the Kubernetes website
content guidelines
https://kubernetes.io/docs/contribute/style/content-guide/
@sftim sftim force-pushed the 20200603_remove_configure_cloud_provider_firewall branch from 06c6724 to fc25b8e Compare June 10, 2020 18:53
@sftim
Copy link
Contributor Author

sftim commented Jun 10, 2020

Rebased

@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit af504d8 into kubernetes:master Jun 10, 2020
@sftim sftim deleted the 20200603_remove_configure_cloud_provider_firewall branch June 9, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants