-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ID Localization for Limit Ranges Concept. #21635
ID Localization for Limit Ranges Concept. #21635
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 96f9756 https://deploy-preview-21635--kubernetes-io-master-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've stopped using capture shortcodes
Please revise this PR to match the recently-updated English language original.
Thanks for the correction, I updated with <-- overview --> and <-- body --> |
745cd53
to
25495f0
Compare
@sftim the deployment is failed due to this heading |
@ariscahyadi if you rebase this pull request against the master branch it should preview OK. |
25495f0
to
e796750
Compare
Thanks @sftim it is work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for localizing this page @ariscahyadi ! Just couple of nits and you are good to go
Mostly:
- Namespace is a Kubernetes object https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#namespace-v1-core so must be written in CamelCase format
- "batasan" (request) and "permintaan" (limit) is a field in Container spec, let's add 1 explanation in the beginning somewhere before using this term?
You're welcome @girikuncoro! It is also a good opportunity for me. |
e796750
to
4c2786a
Compare
4c2786a
to
96f9756
Compare
looking good, thanks for this @ariscahyadi /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girikuncoro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR for addressing translation project as mentioned in #20111