Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID Localization for Limit Ranges Concept. #21635

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

ariscahyadi
Copy link
Contributor

This PR for addressing translation project as mentioned in #20111

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language labels Jun 10, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 10, 2020
@netlify
Copy link

netlify bot commented Jun 10, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 96f9756

https://deploy-preview-21635--kubernetes-io-master-staging.netlify.app

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've stopped using capture shortcodes

Please revise this PR to match the recently-updated English language original.

content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
@ariscahyadi
Copy link
Contributor Author

We've stopped using capture shortcodes

Please revise this PR to match the recently-updated English language original.

Thanks for the correction, I updated with <-- overview --> and <-- body -->

@ariscahyadi
Copy link
Contributor Author

We've stopped using capture shortcodes
Please revise this PR to match the recently-updated English language original.

Thanks for the correction, I updated with <-- overview --> and <-- body -->

@sftim the deployment is failed due to this heading ## {{% heading "whatsnext" %}}, which is the same as the English version.

@sftim
Copy link
Contributor

sftim commented Jun 11, 2020

@ariscahyadi if you rebase this pull request against the master branch it should preview OK.

@ariscahyadi
Copy link
Contributor Author

@ariscahyadi if you rebase this pull request against the master branch it should preview OK.

Thanks @sftim it is work!

Copy link
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for localizing this page @ariscahyadi ! Just couple of nits and you are good to go

Mostly:

content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
content/id/docs/concepts/policy/limit-range.md Outdated Show resolved Hide resolved
@ariscahyadi
Copy link
Contributor Author

Thanks for localizing this page @ariscahyadi ! Just couple of nits and you are good to go

Mostly:

You're welcome @girikuncoro! It is also a good opportunity for me.
But, I think these are what you mean "batasan" (limit) and "permintaan" (request) :)

@girikuncoro
Copy link
Contributor

looking good, thanks for this @ariscahyadi

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit f95b714 into kubernetes:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants