-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bahasa Indonesia translation for managing tls #22312
Add Bahasa Indonesia translation for managing tls #22312
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit c1a180b https://deploy-preview-22312--kubernetes-io-master-staging.netlify.app |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this nice localization, hope you learned something new. I have left few comments, please address them.
Most importantly 2 things:
- "Kamu" should be written in lowercase if not used as sentence opening
- CertificateSigningRequest is Kubernetes API object, should be written in CamelCase
reviewers: | ||
- girikuncoro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed, we'll use reviewers
when we go through the existing/translated docs to maintain quality
|
||
{{% capture overview %}} | ||
|
||
Kubernetes menyediakan API `certificates.k8s.io` yang memungkinkan Kamu membuat sertifikat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Kamu should be lowercase
Kubernetes menyediakan API `certificates.k8s.io` yang memungkinkan Kamu membuat sertifikat | |
Kubernetes menyediakan API `certificates.k8s.io` yang memungkinkan kamu membuat sertifikat |
Certificates created using the `certificates.k8s.io` API are signed by a | ||
dedicated CA. It is possible to configure your cluster to use the cluster root | ||
CA for this purpose, but you should never rely on this. Do not assume that | ||
these certificates will validate against the cluster root CA. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be removed since you have provided the translated paragraph below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol sorry. forget to delete
|
||
## Mempercayai TLS dalam Klaster | ||
|
||
Mempercayai CA kustom dari aplikasi yang berjalan sebagai Pod biasanya memerlukan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kustom is not indonesian word, usually we use "khusus", feel free to suggest other word
Mempercayai CA kustom dari aplikasi yang berjalan sebagai Pod biasanya memerlukan | |
Mempercayai CA khusus dari aplikasi yang berjalan sebagai Pod biasanya memerlukan |
Mempercayai CA kustom dari aplikasi yang berjalan sebagai Pod biasanya memerlukan | ||
beberapa tambahan konfigurasi aplikasi. Kamu harus menambahkan bundel sertifikat CA | ||
ke daftar sertifikat CA yang dipercaya klien atau server TLS. | ||
Misalnya, Kamu akan melakukan ini dengan konfigurasi TLS golang dengan mengurai rantai sertifikat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misalnya, Kamu akan melakukan ini dengan konfigurasi TLS golang dengan mengurai rantai sertifikat | |
Misalnya, kamu akan melakukan ini dengan konfigurasi TLS golang dengan mengurai rantai sertifikat |
|
||
Administrator Kubernetes (dengan izin yang cukup) dapat menyetujui secara manual | ||
(atau menolak) Certificate Signing Requests dengan menggunakan perintah `kubectl certificate | ||
approve` dan `kubectl certificate deny`. Namun jika Kamu bermaksud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve` dan `kubectl certificate deny`. Namun jika Kamu bermaksud | |
approve` dan `kubectl certificate deny`. Namun jika kamu bermaksud |
Administrator Kubernetes (dengan izin yang cukup) dapat menyetujui secara manual | ||
(atau menolak) Certificate Signing Requests dengan menggunakan perintah `kubectl certificate | ||
approve` dan `kubectl certificate deny`. Namun jika Kamu bermaksud | ||
untuk menggunakan API ini secara sering, Kamu dapat mempertimbangkan untuk menulis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
untuk menggunakan API ini secara sering, Kamu dapat mempertimbangkan untuk menulis | |
untuk menggunakan API ini secara sering, kamu dapat mempertimbangkan untuk menulis |
(atau menolak) Certificate Signing Requests dengan menggunakan perintah `kubectl certificate | ||
approve` dan `kubectl certificate deny`. Namun jika Kamu bermaksud | ||
untuk menggunakan API ini secara sering, Kamu dapat mempertimbangkan untuk menulis | ||
Certificate Controller otomatis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certificate Controller otomatis. | |
Certificate _controller_ otomatis. |
|
||
## Peringatan tentang Izin Persetujuan | ||
|
||
Kemampuan untuk menyetujui CSR menentukan siapa yang mempercayai siapa di dalam lingkungan Kamu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kemampuan untuk menyetujui CSR menentukan siapa yang mempercayai siapa di dalam lingkungan Kamu. | |
Kemampuan untuk menyetujui CSR menentukan siapa yang mempercayai siapa di dalam lingkungan kamu. |
Kubernetes _controller manager_ menyediakan implementasi bawaan dari penanda tangan. Untuk | ||
mengaktifkan, berikan parameter `--cluster-signed-cert-file` dan | ||
`--cluster-signed-key-file` ke _controller manager_ dengan _path_ ke | ||
pasangan kunci CA Anda. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pasangan kunci CA Anda. | |
pasangan kunci CA kamu. |
@girikuncoro Thanks for the review gan. I've fixed it. Please kindly check :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imrenagi you will need to rebase this against master and remove the capture shortcodes.
content_template: templates/task | ||
--- | ||
|
||
{{% capture overview %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is out of date since #21359
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've rebased and updated it.
505504a
to
dd9a8a7
Compare
@imrenagi all looking good thanks, hope you learned something from this translation, can you help squashing the commits into 1 good message before we get this in? /lgtm |
Signed-off-by: Imre Nagi <imre.nagi2812@gmail.com> Fix for review Signed-off-by: Imre Nagi <imre.nagi2812@gmail.com> Rebase from master upstream Signed-off-by: Imre Nagi <imre.nagi2812@gmail.com>
ee7b916
to
c1a180b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girikuncoro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding translation for /docs/tasks/tls/managing-tls-in-a-cluster/ in #22296
Signed-off-by: Imre Nagi imre.nagi2812@gmail.com