Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bahasa Indonesia translation for managing tls #22312

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

imrenagi
Copy link
Contributor

@imrenagi imrenagi commented Jul 4, 2020

Adding translation for /docs/tasks/tls/managing-tls-in-a-cluster/ in #22296

Signed-off-by: Imre Nagi imre.nagi2812@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 4, 2020
@netlify
Copy link

netlify bot commented Jul 4, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c1a180b

https://deploy-preview-22312--kubernetes-io-master-staging.netlify.app

@girikuncoro
Copy link
Contributor

/assign

Copy link
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this nice localization, hope you learned something new. I have left few comments, please address them.

Most importantly 2 things:

  • "Kamu" should be written in lowercase if not used as sentence opening
  • CertificateSigningRequest is Kubernetes API object, should be written in CamelCase

https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#certificatesigningrequest-v1beta1-certificates-k8s-io

Comment on lines 4 to 5
reviewers:
- girikuncoro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed, we'll use reviewers when we go through the existing/translated docs to maintain quality


{{% capture overview %}}

Kubernetes menyediakan API `certificates.k8s.io` yang memungkinkan Kamu membuat sertifikat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Kamu should be lowercase

Suggested change
Kubernetes menyediakan API `certificates.k8s.io` yang memungkinkan Kamu membuat sertifikat
Kubernetes menyediakan API `certificates.k8s.io` yang memungkinkan kamu membuat sertifikat

Comment on lines 17 to 21
Certificates created using the `certificates.k8s.io` API are signed by a
dedicated CA. It is possible to configure your cluster to use the cluster root
CA for this purpose, but you should never rely on this. Do not assume that
these certificates will validate against the cluster root CA.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed since you have provided the translated paragraph below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol sorry. forget to delete


## Mempercayai TLS dalam Klaster

Mempercayai CA kustom dari aplikasi yang berjalan sebagai Pod biasanya memerlukan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kustom is not indonesian word, usually we use "khusus", feel free to suggest other word

Suggested change
Mempercayai CA kustom dari aplikasi yang berjalan sebagai Pod biasanya memerlukan
Mempercayai CA khusus dari aplikasi yang berjalan sebagai Pod biasanya memerlukan

Mempercayai CA kustom dari aplikasi yang berjalan sebagai Pod biasanya memerlukan
beberapa tambahan konfigurasi aplikasi. Kamu harus menambahkan bundel sertifikat CA
ke daftar sertifikat CA yang dipercaya klien atau server TLS.
Misalnya, Kamu akan melakukan ini dengan konfigurasi TLS golang dengan mengurai rantai sertifikat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Misalnya, Kamu akan melakukan ini dengan konfigurasi TLS golang dengan mengurai rantai sertifikat
Misalnya, kamu akan melakukan ini dengan konfigurasi TLS golang dengan mengurai rantai sertifikat


Administrator Kubernetes (dengan izin yang cukup) dapat menyetujui secara manual
(atau menolak) Certificate Signing Requests dengan menggunakan perintah `kubectl certificate
approve` dan `kubectl certificate deny`. Namun jika Kamu bermaksud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
approve` dan `kubectl certificate deny`. Namun jika Kamu bermaksud
approve` dan `kubectl certificate deny`. Namun jika kamu bermaksud

Administrator Kubernetes (dengan izin yang cukup) dapat menyetujui secara manual
(atau menolak) Certificate Signing Requests dengan menggunakan perintah `kubectl certificate
approve` dan `kubectl certificate deny`. Namun jika Kamu bermaksud
untuk menggunakan API ini secara sering, Kamu dapat mempertimbangkan untuk menulis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
untuk menggunakan API ini secara sering, Kamu dapat mempertimbangkan untuk menulis
untuk menggunakan API ini secara sering, kamu dapat mempertimbangkan untuk menulis

(atau menolak) Certificate Signing Requests dengan menggunakan perintah `kubectl certificate
approve` dan `kubectl certificate deny`. Namun jika Kamu bermaksud
untuk menggunakan API ini secara sering, Kamu dapat mempertimbangkan untuk menulis
Certificate Controller otomatis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Certificate Controller otomatis.
Certificate _controller_ otomatis.


## Peringatan tentang Izin Persetujuan

Kemampuan untuk menyetujui CSR menentukan siapa yang mempercayai siapa di dalam lingkungan Kamu.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Kemampuan untuk menyetujui CSR menentukan siapa yang mempercayai siapa di dalam lingkungan Kamu.
Kemampuan untuk menyetujui CSR menentukan siapa yang mempercayai siapa di dalam lingkungan kamu.

Kubernetes _controller manager_ menyediakan implementasi bawaan dari penanda tangan. Untuk
mengaktifkan, berikan parameter `--cluster-signed-cert-file` dan
`--cluster-signed-key-file` ke _controller manager_ dengan _path_ ke
pasangan kunci CA Anda.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pasangan kunci CA Anda.
pasangan kunci CA kamu.

@imrenagi
Copy link
Contributor Author

imrenagi commented Jul 4, 2020

@girikuncoro Thanks for the review gan. I've fixed it. Please kindly check :D

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imrenagi you will need to rebase this against master and remove the capture shortcodes.

content_template: templates/task
---

{{% capture overview %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of date since #21359

Copy link
Contributor Author

@imrenagi imrenagi Jul 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've rebased and updated it.

@girikuncoro
Copy link
Contributor

@imrenagi all looking good thanks, hope you learned something from this translation, can you help squashing the commits into 1 good message before we get this in?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2020
Signed-off-by: Imre Nagi <imre.nagi2812@gmail.com>

Fix for review

Signed-off-by: Imre Nagi <imre.nagi2812@gmail.com>

Rebase from master upstream

Signed-off-by: Imre Nagi <imre.nagi2812@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2020
@girikuncoro
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 38eaf3b into kubernetes:master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants