Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Slack channel creation example #22606

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Update the Slack channel creation example #22606

merged 1 commit into from
Aug 3, 2020

Conversation

zacharysarah
Copy link
Contributor

This PR updates the Slack channel creation example in the localization guide to match the current path and process.

For reference, see kubernetes/community#4980

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jul 21, 2020
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2020
@zacharysarah
Copy link
Contributor Author

Probably hold this until kubernetes/community#4980 merges. 😅

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@netlify
Copy link

netlify bot commented Jul 21, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 989f223

https://deploy-preview-22606--kubernetes-io-master-staging.netlify.app

@jimangel
Copy link
Member

/lgtm
🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2020
@celestehorgan
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celestehorgan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@kbhawkey
Copy link
Contributor

kbhawkey commented Aug 3, 2020

Hi. I am removing the hold as PR kubernetes/community#4980 has merged.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 879651c into kubernetes:master Aug 3, 2020
@zacharysarah zacharysarah deleted the update-l10n-contrib branch September 1, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

@steveperry-53 steveperry-53 Awaiting requested review from steveperry-53

Assignees

@jimangel jimangel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zacharysarah @jimangel @celestehorgan @k8s-ci-robot @kbhawkey