Improve ConfigMap concept #23807
Merged
Improve ConfigMap concept #23807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/en
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit b1490ef https://deploy-preview-23807--kubernetes-io-master-staging.netlify.app |
feloy
reviewed
Sep 11, 2020
tengqm
force-pushed
the
improve-configmap-concept
branch
from
786f3ca
to
b658708
Compare
kbhawkey
reviewed
Sep 20, 2020
kbhawkey
reviewed
Sep 20, 2020
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
tengqm
force-pushed
the
improve-configmap-concept
branch
from
b658708
to
aea165d
Compare
kbhawkey
reviewed
Sep 21, 2020
| Kubernetes objects that have a `spec`, a ConfigMap has a `data` section to | ||
| store items (keys) and their values. | ||
| Kubernetes objects that have a `spec`, a ConfigMap has `data` field and | ||
| `binaryData` fields. These fields accepts key-value pairs as their values. |
There was a problem hiding this comment.
nit: should it be:
a ConfigMap has data and binaryData fields?
There was a problem hiding this comment.
That suggested wording looks better to me.
sftim
reviewed
Sep 30, 2020
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 457c1edcf66690c403f86ed1bb84761b42a8ff29
|
This PR adds some missing information to the ConfigMap concept page.
tengqm
force-pushed
the
improve-configmap-concept
branch
from
aea165d
to
b1490ef
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5f8e373859025baad59b3d0572e7a3e5671c9ebe
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some missing information to the ConfigMap concept page.