Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information how to enable cronjob controller v2 #24885

Merged
merged 1 commit into from Nov 12, 2020
Merged

Add information how to enable cronjob controller v2 #24885

merged 1 commit into from Nov 12, 2020

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Nov 4, 2020

This is updating documentation as part of the work from moving cronjobs to ga (kubernetes/enhancements#19).

/assign @alaypatel07
for tech review

@k8s-ci-robot
Copy link
Contributor

@soltysh: GitHub didn't allow me to assign the following users: alaypatel07.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is updating documentation as part of the work from moving cronjobs to ga (kubernetes/enhancements#19).

/assign @alaypatel07
for tech review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 4, 2020 •
edited

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 4f0068f

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5fad556996465c00077de954

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2020
@soltysh soltysh mentioned this pull request Nov 4, 2020
Closed
16 tasks
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 4, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 4, 2020
@annajung
Copy link
Contributor

annajung commented Nov 4, 2020

/milestone 1.20
/hold pending merge kubernetes/kubernetes#93370
/assign @somtochiama
/sig apps

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Nov 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Nov 4, 2020
@irvifa
Copy link
Member

irvifa commented Nov 8, 2020

/label tide-merge-squash

@k8s-ci-robot
Copy link
Contributor

@irvifa: The label(s) /label tide-merge-squash cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

In response to this:

/label tide-merge-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irvifa
Copy link
Member

irvifa commented Nov 8, 2020

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 8, 2020
sftim
sftim reviewed Nov 10, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some feedback about wording.

content/en/docs/concepts/workloads/controllers/cron-jobs.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/controllers/cron-jobs.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Nov 10, 2020

/remove-label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 10, 2020
@soltysh
Copy link
Contributor Author

soltysh commented Nov 10, 2020

Updated with comments from @sftim

@annajung
Copy link
Contributor

annajung commented Nov 12, 2020 •
edited

/hold cancel
k/k pr merged

please rebase and address the conflict file and feedback above and I think this is good to merge. Thank you!

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 12, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2020
@soltysh
Copy link
Contributor Author

soltysh commented Nov 12, 2020

@annajung rebased and updated per @sftim comment.

sftim
sftim reviewed Nov 12, 2020
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -402,6 +403,7 @@ Each feature gate is designed for enabling/disabling a specific feature:
Check [Service Account Token Volumes](https://git.k8s.io/community/contributors/design-proposals/storage/svcacct-token-volume-source.md)
for more details.
- `ConfigurableFSGroupPolicy`: Allows user to configure volume permission change policy for fsGroups when mounting a volume in a Pod. See [Configure volume permission and ownership change policy for Pods](/docs/tasks/configure-pod-container/security-context/#configure-volume-permission-and-ownership-change-policy-for-pods) for more details.
- `CronJobControllerV2`: Enable alternative implementation of the CronJob controller.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (doesn't block merge):

Suggested change
- `CronJobControllerV2`: Enable alternative implementation of the CronJob controller.
- `CronJobControllerV2`: Use an alternative implementation of the
{{< glossary_tooltip text="CronJob" term_id="cronjob" >}} controller. Otherwise,
version 1 of the same controller is selected. The version 2 controller provides
experimental performance improvements.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soltysh
Copy link
Contributor Author

soltysh commented Nov 12, 2020

@sftim pushed with your change added

@annajung
Copy link
Contributor

thank you!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00188c31d786b78a549788acdd933ea1115fade9

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 68898b0 into kubernetes:dev-1.20 Nov 12, 2020
@soltysh soltysh deleted the cronjob_alpha branch November 12, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@annajung annajung annajung left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

@zparnold zparnold Awaiting requested review from zparnold

Assignees

@annajung annajung

@somtochiama somtochiama

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@soltysh @k8s-ci-robot @k8sio-netlify-preview-bot @annajung @irvifa @sftim @somtochiama