Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating EndpointSlice docs for 1.20 #24935

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Updating EndpointSlice docs for 1.20 #24935

merged 1 commit into from
Nov 23, 2020

Conversation

robscott
Copy link
Member

@robscott robscott commented Nov 6, 2020 •
edited

This covers kubernetes/enhancements#752 and the changes that were implemented in kubernetes/kubernetes#96440. It also overlaps a bit with #24927.

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Nov 6, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 6, 2020 •
edited

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit c927e9a

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5fb8633d47f2b000071b3fc3

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2020
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2020
@robscott robscott mentioned this pull request Nov 6, 2020
Closed
@annajung
Copy link
Contributor

annajung commented Nov 6, 2020

/assign @kcmartin
/hold pending merge kubernetes/kubernetes#96318
/milestone 1.20

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Nov 6, 2020
@annajung
Copy link
Contributor

Hi @robscott checking in to see if docs are needed here. Based on the comment kubernetes/kubernetes#96318 (comment) looks like GA will be deferred to 1.21. For the small changes you're making for 1.20, does it require docs change?

If so, please remember to retitle and make sure content reflects the latest progress. Thank you!

@robscott robscott changed the title Updating EndpointSlice docs for GA Updating EndpointSlice docs for 1.20 Nov 12, 2020
@robscott
Copy link
Member Author

Thanks for checking in @annajung! I've updated the title of this PR to a be more reflective of the current scope. I'll still need some small doc updates for kubernetes/kubernetes#96440, but they should be relatively minor.

@annajung
Copy link
Contributor

/hold cancel
k/k pr merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2020
@sftim
Copy link
Contributor

sftim commented Nov 14, 2020

This is a placeholder PR

will mark as draft

Feel free to revise the PR description and mark it ready for review when it is.

@sftim sftim marked this pull request as draft November 14, 2020 18:49
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2020
@kcmartin
Copy link
Contributor

Hi @robscott !

A friendly reminder that Docs "Ready for Review" Deadline is this Monday, Nov. 23rd for the 1.20 release.

Please reach out if you have any questions.

@robscott robscott mentioned this pull request Nov 20, 2020
Closed
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2020
@robscott robscott marked this pull request as ready for review November 20, 2020 02:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2020
@robscott
Copy link
Member Author

@sftim Thanks for the feedback here! This PR should be ready for a full review now.

@robscott
Copy link
Member Author

/cc @andrewsykim

@robscott
Updating EndpointSlice docs for Kubernetes 1.20
c927e9a 
This include the new EndpointSliceNodeName and EndpointSliceTerminating
feature gates as well as the deprecation of the Topology field.
@kcmartin
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 720372dd6582e1696d7da541fbcf17cad32b1581

@annajung
Copy link
Contributor

https://deploy-preview-24935--kubernetes-io-vnext-staging.netlify.app/docs/tasks/administer-cluster/enabling-endpointslices/

https://deploy-preview-24935--kubernetes-io-vnext-staging.netlify.app/docs/concepts/services-networking/endpoint-slices/#topology

pages lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit de2de57 into kubernetes:dev-1.20 Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@kcmartin kcmartin kcmartin requested changes

@bowei bowei Awaiting requested review from bowei

@freehan freehan Awaiting requested review from freehan

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

Assignees

@kcmartin kcmartin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@robscott @k8sio-netlify-preview-bot @annajung @sftim @kcmartin @k8s-ci-robot