Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few grammar issues and typos #28332

Merged
merged 2 commits into from Jun 9, 2021
Merged

Fix a few grammar issues and typos #28332

merged 2 commits into from Jun 9, 2021

Conversation

Squidtoon99
Copy link
Contributor

see the API documentation more information
Should be corrected to "documentation for more information" as the sentence is incorrect.

may only compare two resource version for equality
Everywhere else in the paragraph "resource versions" are used, I believe this is just a typo.

The get, list and watch
Missing comma after list to separate the elements

@Squidtoon99
Fix few grammar issues and typos in the blog page
1a5b7d6 
> see the API documentation more information
Should be corrected to "documentation for more information" as the sentence is incorrect.

> may only compare two resource version for equality
Everywhere else in the paragraph "resource versions" are used, I believe this is just a typo.

> The get, list and watch
Missing comma after list to separate the elements
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 8, 2021
@Squidtoon99
Fix typos in blog post
153d221 
> On rare occurences, a 
"occurrences" is misspelled

>  whole list, map or struct
3 elements are missing a comma seperator after map
 
>  there are no way 
are is a plural form while "no way" is a singular subject

> `MergePatch`, `StrategicMergePatch`, `JSONPatch` or `Update`
Missing comma after JSONPatch
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 8, 2021
@netlify
Copy link

netlify bot commented Jun 8, 2021

✔️ Deploy Preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 1a5b7d6

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/60bff0e8fca4430007aad9d9

😎 Browse the preview: https://deploy-preview-28332--kubernetes-io-master-staging.netlify.app

@netlify
Copy link

netlify bot commented Jun 8, 2021

✔️ Deploy Preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 153d221

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/60bff41107a7e800084d2545

😎 Browse the preview: https://deploy-preview-28332--kubernetes-io-master-staging.netlify.app

@kbhawkey
Copy link
Contributor

kbhawkey commented Jun 9, 2021

Thanks for the updates @Squidtoon99 .
/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 9, 2021
@kbhawkey
Copy link
Contributor

kbhawkey commented Jun 9, 2021

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 05c9bda85f8ea7b2a19eb559bd2d7e2eb5578321

@kbhawkey
Copy link
Contributor

kbhawkey commented Jun 9, 2021

/retitle Fix a few grammar issues and typos

@k8s-ci-robot k8s-ci-robot changed the title Fix few grammar issues and typos in the blog page Fix a few grammar issues and typos Jun 9, 2021
@kbhawkey
Copy link
Contributor

kbhawkey commented Jun 9, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit ddc67b8 into kubernetes:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@kbhawkey kbhawkey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Squidtoon99 @kbhawkey @k8s-ci-robot