[hi] Add content/hi/docs/setup/learning-environment/_index.md #29416

Darshnadas · 2021-08-15T16:42:04Z

Localised the website/content/en/docs/setup/learning-environment/_index.md to Hindi langugage.

k8s-ci-robot · 2021-08-15T16:42:11Z

Welcome @Darshnadas!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

netlify · 2021-08-15T16:59:21Z

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: af87620

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61268deb9fd8e30007fc4a96

😎 Browse the preview: https://deploy-preview-29416--kubernetes-io-main-staging.netlify.app

sftim

@Darshnadas I suspect that you might have misunderstood the advice to localizers in the original page.

There is a Netlify redirect from https://kubernetes.io/docs/setup/learning-environment/ to https://kubernetes.io/docs/tasks/tools/

This English page content only exists to provide a navigation stub and to protect in case that redirect is one day removed.

As you're localizing that page, you only need to copy the front matter (the first 4 lines) and add a redirect into /static/_redirects:

redirect /hi/docs/setup/learning-environment/ to https://kubernetes.io/docs/tasks/tools/

[Later,] if you also localize https://kubernetes.io/docs/tasks/tools/, you can change that redirect so that it targets https://kubernetes.io/hi/docs/tasks/tools/

Darshnadas · 2021-08-17T10:58:04Z

@sftim Ohh, okay.

anubha-v-ardhan · 2021-08-20T08:23:47Z

/retitle [hi] Add content/hi/docs/setup/learning-environment/_index.md

anubha-v-ardhan · 2021-09-13T14:54:43Z

@Darshnadas Can you implement the requested changes. We could move towards merging this PR.

anubha-v-ardhan · 2021-10-01T16:40:47Z

@Darshnadas Are you still working on this PR? Can you have a look at the suggestions please.

Darshnadas · 2021-10-05T14:57:25Z

@anubha-v-ardhan Hi, I just checked the comments and will work on the PR.

Darshnadas · 2021-10-05T18:19:25Z

Hi @anubha-v-ardhan I'll implement the changes and update it by tomorrow

Darshnadas · 2021-10-06T15:17:35Z

@anubha-v-ardhan Updated the PR according to the changes, please check it.

Darshnadas · 2021-10-07T14:38:40Z

static/_redirects

 /pt/*         /pt-br/:splat  302!
+
+/docs/tasks/tools/     /hi/docs/setup/learning-environment/    301 


Okay @anubha-v-ardhan

Darshnadas · 2021-10-07T16:21:29Z

@anubha-v-ardhan I did the required changes.

anubha-v-ardhan · 2021-10-07T16:25:34Z

static/_redirects

@@ -506,6 +506,7 @@
 /docs/setup/learning-environment/     /docs/tasks/tools/  302!
 /id/docs/setup/learning-environment/     /id/docs/tasks/tools/  302!
 /zh/docs/setup/learning-environment/     /zh/docs/tasks/tools/  302!
+/hi/docs/setup/learning-environment/ /hi/docs/tasks/tools/ 302!


Suggested change

/hi/docs/setup/learning-environment/ /hi/docs/tasks/tools/ 302!

/hi/docs/setup/learning-environment/ /hi/docs/tasks/tools/ 302!

anubha-v-ardhan · 2021-10-17T10:23:52Z

@Darshnadas Can you implement all the suggestions, Seems like only some of them were done :)

Darshnadas · 2021-10-19T10:36:18Z

@anubha-v-ardhan I changed the requested changes but I don't know which other areas to change or update. It would be much clearer if you point me out the places and then I would change the specific changes

anubha-v-ardhan · 2021-10-20T13:21:46Z

@Darshnadas The changes suggested for statics/_redirects and in #29416 (comment), #29416 (comment) and #29416 (comment).

I think this happened due to making the changes manually, I would recommend to use the commit suggestion button to avoid this. It will also be easier for both you and the reviewer. Don't worry about the no. of commits :)

sftim · 2021-11-26T12:17:15Z

/label tide/merge-method-squash

If you know how to squash commits here @Darshnadas, please do. It's handy but not strictly required.

Darshnadas · 2021-12-13T14:49:57Z

/label tide/merge-method-squash

If you know how to squash commits here @Darshnadas, please do. It's handy but not strictly required.

Okay @sftim :)

sftim · 2021-12-17T14:49:55Z

BTW, I'm still seeing multiple commits. A squash would mean there was 1 commit.

anubha-v-ardhan · 2021-12-18T12:47:34Z

@Darshnadas It would be nice if you can implement #29416 (comment) before squashing :)

Darshnadas · 2021-12-23T14:40:03Z

okay

…

On Sat, Dec 18, 2021, 6:17 PM Anubhav Vardhan ***@***.***> wrote: @Darshnadas <https://github.com/Darshnadas> It would be nice if you can implement #29416 (comment) <#29416 (comment)> before squashing :) — Reply to this email directly, view it on GitHub <#29416 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMOQRCROOVEDBPVR4GMLROLURR7HFANCNFSM5CGK2QNA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

Darshnadas · 2021-12-27T12:25:42Z

okay @anubha-v-ardhan

anubha-v-ardhan

@Darshnadas You can commit the suggestion

anubha-v-ardhan · 2021-12-27T12:27:20Z

static/_redirects

+
 /pt/*         /pt-br/:splat  302!
+
+


Suggested change

/pt/* /pt-br/:splat 302!

/pt/* /pt-br/:splat 302!

anubha-v-ardhan · 2021-12-27T12:47:34Z

/remove-label tide/merge-method-squash

anubha-v-ardhan · 2021-12-27T12:49:10Z

/assign
/lgtm

Thank you @Darshnadas :)

k8s-ci-robot · 2021-12-27T12:49:29Z

LGTM label has been added.

Git tree hash: 21128c7ddb918e475e59bffa773eab72959c57a8

Darshnadas · 2021-12-27T15:55:18Z

/assign @sftim

sftim · 2022-01-01T14:33:26Z

Looks like this was squashed OK (I've been away for yule).

anubha-v-ardhan · 2022-01-02T16:35:04Z

lgtm from my side. @sftim If the changes look good to you, can we merge this.

sftim · 2022-01-03T15:58:47Z

No objections from me.

anubha-v-ardhan · 2022-01-03T16:06:51Z

@sftim I meant can you /approve 😅
I can't due to changes on static/_redirects

sftim · 2022-01-03T16:11:53Z

/approve

k8s-ci-robot · 2022-01-03T16:12:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Darshnadas · 2022-01-04T14:37:59Z

Thank you so much @sftim

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2021

k8s-ci-robot requested review from daminisatya and mittalyashu August 15, 2021 16:42

k8s-ci-robot added language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2021

sftim previously requested changes Aug 15, 2021

View reviewed changes

anubha-v-ardhan mentioned this pull request Aug 16, 2021

[hi] Tracking Hindi localization progress #29353

Closed

52 tasks

mittalyashu assigned Darshnadas Aug 17, 2021

anubha-v-ardhan mentioned this pull request Aug 17, 2021

REQUEST: New membership for anubha-v-ardhan kubernetes/org#2895

Closed

7 tasks

k8s-ci-robot changed the title ~~Add content/hi/docs/setup/learning-environment/_index.md~~ [hi] Add content/hi/docs/setup/learning-environment/_index.md Aug 20, 2021

Darshnadas changed the base branch from main to dev-1.22-hi.1 September 13, 2021 08:25

Darshnadas force-pushed the darshna-localize branch from af87620 to b31d559 Compare October 6, 2021 15:16

Darshnadas commented Oct 7, 2021

View reviewed changes

Darshnadas force-pushed the darshna-localize branch from b31d559 to c17d383 Compare October 7, 2021 16:20

anubha-v-ardhan suggested changes Oct 7, 2021

View reviewed changes

Darshnadas force-pushed the darshna-localize branch from c17d383 to 5854962 Compare October 16, 2021 16:23

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 25, 2021

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 26, 2021

Darshnadas force-pushed the darshna-localize branch from 677958c to 49a17a7 Compare December 14, 2021 16:00

Garima-Negi mentioned this pull request Dec 21, 2021

REQUEST: New membership for <@Garima-Negi> kubernetes/org#3154

Closed

7 tasks

anubha-v-ardhan suggested changes Dec 27, 2021

View reviewed changes

Add content/hi/docs/setup/learning-environment/_index.md

bf31565

Darshnadas force-pushed the darshna-localize branch from 49a17a7 to bf31565 Compare December 27, 2021 12:40

k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 27, 2021

k8s-ci-robot assigned anubha-v-ardhan Dec 27, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2021

k8s-ci-robot assigned sftim Dec 27, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2022

k8s-ci-robot merged commit b855e0d into kubernetes:dev-1.22-hi.1 Jan 3, 2022

		/pt/* /pt-br/:splat 302!

		/docs/tasks/tools/ /hi/docs/setup/learning-environment/ 301

	/hi/docs/setup/learning-environment/ /hi/docs/tasks/tools/ 302!
	/hi/docs/setup/learning-environment/ /hi/docs/tasks/tools/ 302!

[hi] Add content/hi/docs/setup/learning-environment/_index.md #29416

[hi] Add content/hi/docs/setup/learning-environment/_index.md #29416

Conversation

Darshnadas commented Aug 15, 2021

k8s-ci-robot commented Aug 15, 2021

netlify bot commented Aug 15, 2021 • edited Loading

sftim left a comment • edited Loading

Choose a reason for hiding this comment

Darshnadas commented Aug 17, 2021

anubha-v-ardhan commented Aug 20, 2021

anubha-v-ardhan commented Sep 13, 2021

anubha-v-ardhan commented Oct 1, 2021

Darshnadas commented Oct 5, 2021

Darshnadas commented Oct 5, 2021

Darshnadas commented Oct 6, 2021

Darshnadas Oct 7, 2021

Choose a reason for hiding this comment

Darshnadas commented Oct 7, 2021

anubha-v-ardhan Oct 7, 2021

Choose a reason for hiding this comment

anubha-v-ardhan commented Oct 17, 2021

Darshnadas commented Oct 19, 2021

anubha-v-ardhan commented Oct 20, 2021 • edited Loading

sftim commented Nov 26, 2021

Darshnadas commented Dec 13, 2021

sftim commented Dec 17, 2021

anubha-v-ardhan commented Dec 18, 2021

Darshnadas commented Dec 23, 2021 via email

Darshnadas commented Dec 27, 2021

anubha-v-ardhan left a comment

Choose a reason for hiding this comment

anubha-v-ardhan Dec 27, 2021

Choose a reason for hiding this comment

Darshnadas Dec 27, 2021

Choose a reason for hiding this comment

anubha-v-ardhan commented Dec 27, 2021

anubha-v-ardhan commented Dec 27, 2021 • edited Loading

k8s-ci-robot commented Dec 27, 2021

Darshnadas commented Dec 27, 2021

sftim commented Jan 1, 2022

anubha-v-ardhan commented Jan 2, 2022 • edited Loading

sftim commented Jan 3, 2022

anubha-v-ardhan commented Jan 3, 2022 • edited Loading

sftim commented Jan 3, 2022

k8s-ci-robot commented Jan 3, 2022

Darshnadas commented Jan 4, 2022

netlify bot commented Aug 15, 2021 •

edited

Loading

sftim left a comment •

edited

Loading

anubha-v-ardhan commented Oct 20, 2021 •

edited

Loading

anubha-v-ardhan commented Dec 27, 2021 •

edited

Loading

anubha-v-ardhan commented Jan 2, 2022 •

edited

Loading

anubha-v-ardhan commented Jan 3, 2022 •

edited

Loading