Fix a typo and update one url #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a typo and update one url
k8s-ci-robot
added
the
cncf-cla: yes
mikedanese
reviewed
Mar 28, 2017
| @@ -20,7 +20,7 @@ Multiple kubeconfig files are allowed, if specified explicitly. At runtime they | |||
|
|
|||
| ## Related discussion | |||
|
|
|||
| http://issue.k8s.io/1755 | |||
|
@chenopis why did you merge this when I had an outstanding comment? |
|
@mikedanese Sorry. issue.k8s.io/1755 redirects to github.com/kubernetes/kubernetes/issues/1755 so I thought using the final URL was fine. Is it better to use the issue.k8s.io format? I can revert just that part if needed. |
|
Since the compact form, http://issue.k8s.io/1755, makes things simpler, I'm reverting to that in PR #3047 and turning it into a clickable link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo and update one url
This change is