Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise concept & reference docs for Services, Ingress & networking #30817

Closed
wants to merge 1 commit into from

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Dec 8, 2021

Overall PR (changes have been split out).

Individual PRs:


The effect of this PR, overall:

/language en
/label refactor
/sig network

Helps with #14770

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/network Categorizes an issue or PR as relevant to SIG Network. refactor Indicates a PR with large refactoring changes e.g. removes files or moves content cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 8, 2021
@netlify
Copy link

netlify bot commented Dec 8, 2021

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 613d6b8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/649ed8b686967100083399a3
😎 Deploy Preview https://deploy-preview-30817--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2022
@sftim sftim force-pushed the 20211208_redo_service_docs branch 2 times, most recently from 47a4706 to bf9ad16 Compare January 14, 2022 16:01
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 2, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2022
@sftim
Copy link
Contributor Author

sftim commented Mar 3, 2022

May help with #32013

@chrismetz09
Copy link
Contributor

chrismetz09 commented Mar 22, 2022

The service glossary entry ({{< glossary_definition term_id="service" length="short" >}}) does not look right. Perhaps replace with:

Kubernetes defines a Service as a scalable and resilient method for exposing an application service running on one or more pods in your cluster. Kubernetes employs several techniques to enable a service including per-Pod IPv4/IPv6 addressing, dynamic Pod creation and deletion, Pod replicas and service discovery.

@chrismetz09
Copy link
Contributor

In service.md file under #services-in-kubernetes, wondering if micro-service term should be included. What about the abstraction? Isn't it just one piece of a service? A text suggestion:

In Kubernetes, a Service employs an abstraction which defines a logical set of Pods and a policy by which to access these pods.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2023
@sftim sftim force-pushed the 20211208_redo_service_docs branch from 6deaa65 to 93d7531 Compare April 13, 2023 16:42
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 13, 2023
@sftim sftim force-pushed the 20211208_redo_service_docs branch from 93d7531 to 48cb5c2 Compare May 16, 2023 08:09
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 16, 2023
@sftim
Copy link
Contributor Author

sftim commented May 16, 2023

Also see #41173

@sftim
Copy link
Contributor Author

sftim commented May 16, 2023

/remove-label refactor

@k8s-ci-robot k8s-ci-robot removed the refactor Indicates a PR with large refactoring changes e.g. removes files or moves content label May 16, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2023
@sftim sftim force-pushed the 20211208_redo_service_docs branch from 48cb5c2 to 8e92a98 Compare June 10, 2023 08:44
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2023
@sftim sftim force-pushed the 20211208_redo_service_docs branch from 8e92a98 to 9892771 Compare June 26, 2023 20:45
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shannonxtreme
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim sftim force-pushed the 20211208_redo_service_docs branch from 9892771 to 613d6b8 Compare June 30, 2023 13:29
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 30, 2023
@sftim
Copy link
Contributor Author

sftim commented Jul 2, 2023

All split out PRs have merged or been superseded.

/close

@k8s-ci-robot
Copy link
Contributor

@sftim: Closed this PR.

In response to this:

All split out PRs have merged or been superseded.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim sftim deleted the 20211208_redo_service_docs branch September 23, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet