Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak headings for port definitions within Service concept #40227

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Tweak headings for port definitions within Service concept #40227

merged 1 commit into from
Mar 25, 2023

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Mar 22, 2023

Redo headings for port definitions

Split out from #30817

@sftim
Revise Service concept
ccbe92e 
Redo headings for port definitions
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2023
@sftim
Copy link
Contributor Author

sftim commented Mar 22, 2023

/retitle Tweak headings for port definitions within Service concept

@k8s-ci-robot k8s-ci-robot changed the title Revise Service concept Tweak headings for port definitions within Service concept Mar 22, 2023
@sftim sftim mentioned this pull request Mar 22, 2023
Closed
@netlify
Copy link

netlify bot commented Mar 22, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ccbe92e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/641b1870eafdaa0008d0ecbb
😎 Deploy Preview https://deploy-preview-40227--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Mar 22, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4a528c0ae77602deceb9aaf59812818494e65341

divya-mohan0209
divya-mohan0209 reviewed Mar 25, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 324c386 into kubernetes:main Mar 25, 2023
@sftim sftim deleted the 20230322_revise_service_concept branch October 12, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @tengqm @k8s-ci-robot @divya-mohan0209