-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add note about Terminating pods when rolling out a Deployment #31603
Conversation
please review @soltysh @ravisantoshgudimetla |
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 88d3303 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6217d96147a225000837b62d 😎 Browse the preview: https://deploy-preview-31603--kubernetes-io-main-staging.netlify.app |
ae7d53b
to
6176445
Compare
- fix number of Pods when describing the rollout functionality
6176445
to
88d3303
Compare
/approve |
@tengqm: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tengqm: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig apps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 69fd3543d0c2f1b60e079b4772e1b181d933e841
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue was brought up in sig-apps meeting and it was decided to better document a behaviour of terminating pods in a deployment.
I also noticed there were some inconsistencies in a current documentation in number of example pods so I piggy-bagged the fix to this PR as well.