Stop recommending people scrape auto-generated service account tokens #31845
Conversation
k8s-ci-robot
added
sig/auth
|
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 3d15ef3 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62167cc9bc5325000788ff67 😎 Browse the preview: https://deploy-preview-31845--kubernetes-io-main-staging.netlify.app |
| The tokens obtained using this method have bounded lifetimes, and are automatically | ||
| invalidated when the Pod they are mounted into is deleted. | ||
|
|
||
| Service account token secrets can still be created manually if you need a token that never expires, |
There was a problem hiding this comment.
Also, service account token secrets support revocation, which I don't know that TokenRequest allows in a meaningful way. It's unfortunate that to get revocation, you need to have the contents visible to the client, but I guess it's a useful tradeoff.
There was a problem hiding this comment.
tokens returned by tokenrequest can be revoked by deleting the associated service account. A secondary object (pod or secret) can also be referenced in the token request, and deletion of that secondary object revokes the token as well
There was a problem hiding this comment.
Is there doc that describes how to bind the token request to a secret so it can be revoked? I guess not - I can open an issue to track that.
There was a problem hiding this comment.
@smarterclayton yes please (to the new issue)
There was a problem hiding this comment.
just the field-level API doc. there's a kubectl create token command coming in 1.24 that has CLI support for binding to a secret object... that might be nice to include in the doc
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e620c272170c8bda58875602f00abd940dd5edd4
|
There was a problem hiding this comment.
Thanks for this, that's a sound overall improvement. I've added inline feedback.
Also, a specific query:
Should the annotation kubernetes.io/service-account-name (or perhaps kubernetes.io/service-account.name) be listed in https://kubernetes.io/docs/reference/labels-annotations-taints/?
(I don't see it).
I'm trying to get to a point where all the annotations we either use in code or recommend in docs, that are inside kubernetes.io, are registered and documented.
content/en/docs/tasks/access-application-cluster/access-cluster.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/access-application-cluster/access-cluster.md
Outdated
Show resolved
Hide resolved
| Automatic creation of API credentials in secrets to mount into running pods | ||
| is no longer used in v1.22 and newer versions. Instead, API credentials are | ||
| obtained directly by using the [TokenRequest](/docs/reference/kubernetes-api/authentication-resources/token-request-v1/) API, | ||
| and are mounted into Pods using a [projected volume](/docs/reference/access-authn-authz/service-accounts-admin/#bound-service-account-token-volume). | ||
| The tokens obtained using this method have bounded lifetimes, and are automatically | ||
| invalidated when the Pod they are mounted into is deleted. |
There was a problem hiding this comment.
Are TokenRequests a subresource of ServiceAccount? I think they are, but it's not 100% clear from my understanding of what counts as a subresource.
We should aim to clarify that in the reference for ServiceAccount: https://kubernetes.io/docs/reference/access-authn-authz/service-accounts-admin/
There was a problem hiding this comment.
OK, then I recommend using the term subresource to make that more clear.
|
Also, what'd be really nice is a concept explanation for ServiceAccount; right now there isn't one. I'd either
|
liggitt
force-pushed
the
manual-token
branch
from
a70dc3e
to
3d15ef3
Compare
k8s-ci-robot
removed
the
lgtm
|
fixed up style issues |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5aefc8e0a6a6c4af8989a5f4bafceb9091b7c5eb
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimangel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
/sig auth
/cc @smarterclayton @zshihang