Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark OpenStack Cinder CSI migration as GA for 1.24 #31969

Closed
wants to merge 1 commit into from
Closed

Mark OpenStack Cinder CSI migration as GA for 1.24 #31969

wants to merge 1 commit into from

Conversation

dims
Copy link
Member

@dims dims commented Feb 28, 2022

Following up to kubernetes/kubernetes#107462 and kubernetes/enhancements#3126

Signed-off-by: Davanum Srinivas davanum@gmail.com

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Feb 28, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2022
@netlify
Copy link

netlify bot commented Feb 28, 2022 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 911c8bf

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/621cf05df1492f00079f3299

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pi-victor after the PR has been reviewed.
You can assign the PR to them by writing /assign @pi-victor in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 28, 2022
@dims dims closed this Feb 28, 2022
@dims dims reopened this Feb 28, 2022
@dims dims force-pushed the CSIMigrationOpenStack-is-ga-in-1.24 branch from e713606 to 2efa0ff Compare February 28, 2022 15:54
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2022
@dims
CSIMigrationOpenStack will be GA in 1.24
911c8bf 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the CSIMigrationOpenStack-is-ga-in-1.24 branch from 2efa0ff to 911c8bf Compare February 28, 2022 15:55
@dims
Copy link
Member Author

dims commented Feb 28, 2022

/assign @xing-yang

tengqm
tengqm reviewed Feb 28, 2022
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Comment on lines -88 to -89
| `CSIMigrationOpenStack` | `false` | Alpha | 1.14 | 1.17 |
| `CSIMigrationOpenStack` | `true` | Beta | 1.18 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines should be migrated into the second table rather than simply dropped from the first table. I.e. please move CSIMigrationOpenStack to somewhere around line 264 and mark it as GA.

@sftim
Copy link
Contributor

sftim commented Mar 1, 2022

/retitle Mark OpenStack Cinder CSI migration as GA for 1.24

@k8s-ci-robot k8s-ci-robot changed the title CSIMigrationOpenStack will be GA in 1.24 Mark OpenStack Cinder CSI migration as GA for 1.24 Mar 1, 2022
sftim
sftim reviewed Mar 1, 2022
View reviewed changes
content/en/docs/concepts/storage/volumes.md
You can disable Cinder CSI migration for your cluster by setting the `CSIMigrationOpenStack`
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/) to `false`.
If you disable the `CSIMigrationOpenStack` feature, the in-tree Cinder volume plugin takes responsibility
for all aspects of Cinder volume storage management.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect to see something like this as well:

#### OpenStack CSI migration complete

{{< feature-state for_k8s_version="v1.24" state="FIXME" >}}
To disable the `cinder` storage plugin from being loaded by the controller manager
and the kubelet, set the `InTreePluginFIXMEUnregister` flag to `true`.

similar to other storage mechanisms that support using CSI rather than in-tree drivers.

Is that the case for Cinder? If it's not, do we need to add some text to document why / what readers should do instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that there is an existing InTreePluginOpenStackUnregister feature gate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. This section is missing for Cinder CSI migration.
Feature state for InTreePluginOpenStackUnregister is Alpha.

@tengqm
Copy link
Contributor

tengqm commented Mar 25, 2022

@dims friendly ping.

@dims
Copy link
Member Author

dims commented Mar 25, 2022

@tengqm distracted by a few other things. Do you mind taking this over? (copy this commit to your own PR and make the necessary changes!)

thanks,

@tengqm
Copy link
Contributor

tengqm commented Mar 25, 2022

@tengqm distracted by a few other things. Do you mind taking this over? (copy this commit to your own PR and make the necessary changes!)

Will do.

@tengqm tengqm mentioned this pull request Mar 25, 2022
Merged
@tengqm
Copy link
Contributor

tengqm commented Mar 25, 2022

/close
Superseded by #32495.

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closed this PR.

In response to this:

/close
Superseded by #32495.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@tengqm tengqm tengqm left review comments

@sftim sftim sftim left review comments

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

@thockin thockin Awaiting requested review from thockin

Assignees

@xing-yang xing-yang

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dims @k8s-ci-robot @sftim @tengqm @xing-yang