Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy-url example to kubectl documentation #32245

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Add proxy-url example to kubectl documentation #32245

merged 2 commits into from
Mar 22, 2022

Conversation

RoSk0
Copy link
Contributor

@RoSk0 RoSk0 commented Mar 14, 2022

I was pointed to kubernetes/client-go#351 (comment) but wasn't able to find any mention of proxy-url in docs.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 14, 2022
@netlify
Copy link

netlify bot commented Mar 14, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 945bf31

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62325877868a5c000a752562

😎 Browse the preview: https://deploy-preview-32245--kubernetes-io-main-staging.netlify.app

jihoon-seo
jihoon-seo reviewed Mar 16, 2022
View reviewed changes
Copy link
Member

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoSk0 PTAL!

content/en/docs/concepts/configuration/organize-cluster-access-kubeconfig.md Outdated Show resolved Hide resolved
@RoSk0 @jihoon-seo
Fix typo
945bf31 
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
@RoSk0
Copy link
Contributor Author

RoSk0 commented Mar 16, 2022 •
edited
Loading

@RoSk0 PTAL!

HI @jihoon-seo , I would appreciate meaningful message instead of the set of characters.

@tengqm
Copy link
Contributor

tengqm commented Mar 17, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
@jihoon-seo
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 17, 2022
@reylejano
Copy link
Member

Preview of updated page:
https://deploy-preview-32245--kubernetes-io-main-staging.netlify.app/docs/concepts/configuration/organize-cluster-access-kubeconfig/

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7facfb56676a36844d228e328834843a3e9e23d1

@k8s-ci-robot k8s-ci-robot merged commit 7add16b into kubernetes:main Mar 22, 2022
xurizaemon added a commit to xurizaemon/website that referenced this pull request Apr 13, 2022
@xurizaemon
Docs fix for kubectl proxy configuration
6893daa 
Follow-up to kubernetes#32245
@xurizaemon xurizaemon mentioned this pull request Apr 13, 2022
Merged
xurizaemon added a commit to xurizaemon/website that referenced this pull request Jun 14, 2022
@xurizaemon
Docs fix for kubectl proxy configuration
57f7b93 
Follow-up to kubernetes#32245
xurizaemon added a commit to xurizaemon/website that referenced this pull request Jun 14, 2022
@xurizaemon
Docs fix for kubectl proxy configuration
81fe9b4 
Follow-up to kubernetes#32245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoon-seo jihoon-seo jihoon-seo left review comments

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@sftim sftim Awaiting requested review from sftim

Assignees

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RoSk0 @tengqm @k8s-ci-robot @jihoon-seo @reylejano