Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs fix for kubectl proxy configuration #32894

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Docs fix for kubectl proxy configuration #32894

merged 2 commits into from
Jun 14, 2022

Conversation

xurizaemon
Copy link
Contributor

@xurizaemon xurizaemon commented Apr 13, 2022 •
edited
Loading

Follow-up to #32245

The proxy-url setting is per cluster in ~/.kube/config, not a top-level value.

At least, using a top-level entry didn't work for me when I tried it just now! (kubectl v1.23.5)

I use the config setting for all clusters I access.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 13, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xurizaemon / name: Chris Burgess (6893daa)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 13, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @xurizaemon!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 13, 2022
@netlify
Copy link

netlify bot commented Apr 13, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 81fe9b4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62a86415b0c3bd0008cd3635
😎 Deploy Preview https://deploy-preview-32894--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Apr 13, 2022

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Apr 13, 2022
@xurizaemon xurizaemon mentioned this pull request Apr 25, 2022
Closed
@reylejano
Copy link
Member

Hi @kubernetes/sig-cli-kubectl-maintainers , please take a look at this PR and give a technical review

Sea-n
Sea-n reviewed Jun 8, 2022
View reviewed changes
Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a nitpick, please take a look.

content/en/docs/concepts/configuration/organize-cluster-access-kubeconfig.md Outdated Show resolved Hide resolved
@zacharysarah
Copy link
Contributor

@xurizaemon 👋🏻 Please feel free to /reopen when you're ready to respond to feedback.

/close

@k8s-ci-robot
Copy link
Contributor

@zacharysarah: Closed this PR.

In response to this:

@xurizaemon 👋🏻 Please feel free to /reopen when you're ready to respond to feedback.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xurizaemon
Copy link
Contributor Author

xurizaemon commented Jun 14, 2022 •
edited
Loading

/reopen

to apply suggestion :)

@xurizaemon
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

@xurizaemon: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2022
@xurizaemon
Copy link
Contributor Author

Rebased & fixed the extra space. Thanks!

@zacharysarah
Copy link
Contributor

LGTM from a docs perspective.

@kubernetes/sig-cli-kubectl-maintainers 👋🏻 Feel free to follow with any corrections needed.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bd39c881a71ecda1835b992cda1b479827dc3304

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 553dc2f into kubernetes:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sea-n Sea-n Sea-n left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

Assignees

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xurizaemon @k8s-ci-robot @sftim @reylejano @zacharysarah @Sea-n